Add risk warning and decoding to message signing#63
Open
Jim8y wants to merge 3 commits into
Open
Conversation
SignMessagePopup showed only the raw (often hex/base64) payload with no framing, so users blind-signed opaque blobs. Add a prominent risk warning and a best-effort decode that surfaces the human-readable message when the payload is hex/base64. Builds for net10.0-android (0 errors).
There was a problem hiding this comment.
Pull request overview
Adds user-facing anti–blind-signing context to the message signing flow by introducing a prominent risk warning and a best-effort “decoded” view of message payloads (hex/base64) in SignMessagePopup, plus new localized strings to support the UI.
Changes:
- Add localized strings for a sign-message risk warning and a decoded-message label.
- Update
SignMessagePopupUI to show a warning banner and (when available) a decoded message section. - Add best-effort decoding logic in
SignMessagePopup.xaml.csto surface human-readable content.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| OneGateApp/Properties/Strings.resx | Adds new base (English) resource strings for decoded message and risk warning. |
| OneGateApp/Properties/Strings.zh-Hans.resx | Adds Simplified Chinese translations for the new strings. |
| OneGateApp/Properties/Strings.zh-Hant.resx | Adds Traditional Chinese translations for the new strings. |
| OneGateApp/Properties/Strings.Designer.cs | Exposes the new resource keys via strongly-typed properties. |
| OneGateApp/Controls/Popups/SignMessagePopup.xaml | Adds the warning banner and conditional decoded-message UI section. |
| OneGateApp/Controls/Popups/SignMessagePopup.xaml.cs | Implements best-effort decoding and binds it into the popup view model. |
Files not reviewed (1)
- OneGateApp/Properties/Strings.Designer.cs: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Handled the open #63 review threads. Changes:
Validation:
Note:
Screenshots: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SignMessagePopupshowed only the raw message payload (often hex/base64) with no risk framing — classic blind-signing. This adds:Notes
SignMessagePopupis touched by no open PR (Add transaction preview v2 #50's transaction-preview work is onSendTransactionPopup, a different popup).