Skip to content

Polish design system styles#57

Open
Jim8y wants to merge 3 commits into
neoorder:masterfrom
Jim8y:codex/p10-design-system-polish
Open

Polish design system styles#57
Jim8y wants to merge 3 commits into
neoorder:masterfrom
Jim8y:codex/p10-design-system-polish

Conversation

@Jim8y

@Jim8y Jim8y commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Scope

  • Tighten the global Card style to an 8px radius so app cards match the tighter page-level card language.
  • Give the global Field style a consistent text-box background, stroke, and 8px radius.
  • Apply iOS minimal SearchBar styling globally to avoid dark native search backgrounds on new search surfaces.
  • Use the OneGate brand color for selected bottom-tab icons and labels.

Validation

  • iOS Simulator: dotnet build OneGateApp/OneGateApp.csproj -f net10.0-ios -p:RuntimeIdentifier=iossimulator-arm64 -p:BuildIpa=false -p:EnableCodeSigning=false
  • iOS Simulator: installed and launched on iPhone 17 Pro / iOS 26.5, opened Apps, verified SearchBar, card styling, segmented filters, and selected tab color.
  • Android Emulator: dotnet build OneGateApp/OneGateApp.csproj -f net10.0-android -p:RuntimeIdentifier=android-arm64 -p:AndroidSdkDirectory=/opt/homebrew/share/android-commandlinetools -p:JavaSdkDirectory=/opt/homebrew/Cellar/openjdk@17/17.0.19/libexec/openjdk.jdk/Contents/Home -p:EmbedAssembliesIntoApk=true
  • Android Emulator: installed and launched on emulator-5554, opened Apps, verified cards, filters, and selected tab color.
  • Android crash buffer: empty after validation.

Screenshots

Known limitations

  • This is a style-system polish PR only. It does not redesign page layout, change navigation behavior, or alter existing feature flows.

Copilot AI review requested due to automatic review settings June 21, 2026 07:12
@Jim8y

Jim8y commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

Review update: Design System Polish

Addressed Erik's brand-color comment in commit 81d5c02:

  • reverted selected bottom-tab icon/label color from Brand back to Primary
  • kept the scoped design-system polish for card radius, field styling, and iOS minimal SearchBar style
  • avoided treating NEO green as OneGate's selected navigation color

Screenshots are GitHub Release assets from the fork and are not committed to this repository.

Platform Screenshot
iOS Simulator - iPhone 17 Pro, iOS 26.5 iOS selected tab primary color
Android Emulator - Android 16 arm64, emulator-5554 Android selected tab primary color

Validation:

  • git diff --check passed
  • iOS build passed: DEVELOPER_DIR=/Applications/Xcode-26.5.0.app/Contents/Developer dotnet build OneGateApp/OneGateApp.csproj -f net10.0-ios -p:RuntimeIdentifier=iossimulator-arm64 -p:BuildIpa=false -p:EnableCodeSigning=false
  • Android build passed: JAVA_HOME=/opt/homebrew/Cellar/openjdk@17/17.0.19/libexec/openjdk.jdk/Contents/Home dotnet build OneGateApp/OneGateApp.csproj -f net10.0-android -p:RuntimeIdentifier=android-arm64 -p:AndroidSdkDirectory=/opt/homebrew/share/android-commandlinetools -p:JavaSdkDirectory=/opt/homebrew/Cellar/openjdk@17/17.0.19/libexec/openjdk.jdk/Contents/Home -p:EmbedAssembliesIntoApk=true
  • iOS Simulator verified: Home tab selected state renders with Primary, not green
  • Android Emulator verified: Home tab selected state renders with Primary, not green; crash buffer was empty

Known existing warnings: SQLitePCLRaw NU1903; iOS also reports existing duplicate ImageAsset warnings on this branch.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR polishes the app’s global design system styling in MAUI to make cards/fields tighter and more consistent, apply an iOS “Minimal” SearchBar appearance globally, and align selected tab colors with the OneGate brand color.

Changes:

  • Updated global Card and Field Border styles (8px corner radius; Field now uses TextBox background + 1px stroke).
  • Applied ios:SearchBar.SearchBarStyle="Minimal" in the global SearchBar style.
  • Switched selected bottom-tab icon/label colors from Primary to Brand (Shell style + checked FontImageSources).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
OneGateApp/Resources/Styles/Styles.xaml Tightens global card/field styling, sets iOS SearchBar minimal style globally, and updates Shell selected tab colors to Brand.
OneGateApp/AppShell.xaml Updates checked tab FontImageSource colors to Brand to match the updated Shell selected-state styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread OneGateApp/AppShell.xaml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants