Add global search#54
Conversation
|
Updated durable iOS and Android simulator verification screenshots:
Both screenshots verify |
There was a problem hiding this comment.
Pull request overview
Adds a new Global Search experience to the MAUI app, reachable from the Home toolbar, enabling search across wallet assets, saved contacts, and regular dApps while reusing existing navigation flows.
Changes:
- Add
GlobalSearchPage(XAML + code-behind) that loads assets/contacts/dApps and filters results. - Add a Home toolbar entry that navigates to the new search route.
- Add localized string resources (EN + zh-Hans) and register the Shell route.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| OneGateApp/Properties/Strings.zh-Hans.resx | Adds zh-Hans localization for the Global Search page title. |
| OneGateApp/Properties/Strings.resx | Adds default (neutral) localization for the Global Search page title. |
| OneGateApp/Properties/Strings.Designer.cs | Exposes the new Strings.GlobalSearch resource accessor. |
| OneGateApp/Pages/HomePage.xaml | Adds a primary toolbar item that navigates to Global Search. |
| OneGateApp/Pages/GlobalSearchPage.xaml.cs | Implements loading + filtering + navigation for global search results. |
| OneGateApp/Pages/GlobalSearchPage.xaml | Defines the Global Search UI and binds to results/loading state. |
| OneGateApp/AppShell.xaml.cs | Registers the home/search Shell route for navigation. |
Files not reviewed (1)
- OneGateApp/Properties/Strings.Designer.cs: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Use real icons for tokens and dapps? |
|
@erikzhang fixed in |
Scope
dapps/recentbefore other result groups and mark them with a localized recently-used badge.Review follow-up
Validation
git diff --checkStrings*.resxfiles: 285 keys.vault, verifiedOneGate Vaultappears beforeVaultenwith the最近使用badge.vault, verifiedOneGate Vaultappears beforeVaultenwith theRecently usedbadge, and checked the crash buffer was empty.Screenshots
Known limitations