[codex] Add address book transfer history#31
Closed
Jim8y wants to merge 7 commits into
Closed
Conversation
Contributor
|
Please remove the screenshots. |
Contributor
Author
Contributor
Author
|
Reviewed the external PR #31 audit and addressed the wallet-safety blockers. Fixed:
Reviewed but not expanded in this patch:
Validation repeated:
Known warning remains pre-existing: SQLitePCLRaw NU1903 warnings from the dependency graph. No screenshots or binary assets were added to the PR file tree. |
# Conflicts: # OneGateApp/Data/ApplicationDbContext.cs
Contributor
|
Please remove irrelevant changes. |
Contributor
Author
|
Follow-up on the scope feedback:
I left this original PR open to preserve the review history and avoid a destructive force-push. The remaining address-book UI/send integration can be split after #37 or converted into a smaller replacement PR if preferred. |
This was referenced Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







English
Purpose
This PR adds a first-pass professional address book for OneGate wallet transfers. The goal is to make recipient selection safer and more user-friendly by supporting saved contacts, recent transfer recipients, name/address search, transfer-aware contact details, and consistent recipient selection in token and NFT send flows.
What changed
AddressBookServicethat normalizes Neo addresses, resolves saved contact names, returns address suggestions, and records successful transfer recipients.ContactTransfershistory table and migration so saved contacts can show related transfer records.User impact
Validation
xmllint --noout OneGateApp/Pages/*.xaml OneGateApp/Controls/Popups/*.xaml OneGateApp/AppShell.xamlpassed.git diff --checkpassed.dotnet build OneGateApp/OneGateApp.csproj -f net10.0-android -p:RuntimeIdentifier=android-arm64 -p:EmbedAssembliesIntoApk=true.dotnet build OneGateApp/OneGateApp.csproj -f net10.0-ios -p:RuntimeIdentifier=iossimulator-arm64 -p:EnableCodeSigning=false -p:CodesignKey= -p:CodesignProvision= -p:ProvisioningType=automatic.emulator-5554, launched OneGate, and verified Address Book list, contact detail, focused recipient suggestions, selected recipient preview, and recipient picker popup through real UI operations.NU1903warnings forSQLitePCLRaw.lib.e_sqlite3*; this PR does not add those package advisories.中文
目的
这个 PR 为 OneGate 钱包转账添加第一轮专业地址簿。目标是通过保存联系人、最近转账收款人、姓名/地址搜索、与转账历史关联的联系人详情,以及在代币和 NFT 发送流程中一致的收款人选择体验,让收款人选择更安全、更用户友好。
修改内容
AddressBookService,用于规范化 Neo 地址、解析已保存联系人名称、返回地址建议,并记录成功转账的收款人。ContactTransfers历史表和迁移,让已保存联系人可以展示关联转账记录。用户影响
验证
xmllint --noout OneGateApp/Pages/*.xaml OneGateApp/Controls/Popups/*.xaml OneGateApp/AppShell.xaml通过。git diff --check通过。dotnet build OneGateApp/OneGateApp.csproj -f net10.0-android -p:RuntimeIdentifier=android-arm64 -p:EmbedAssembliesIntoApk=true。dotnet build OneGateApp/OneGateApp.csproj -f net10.0-ios -p:RuntimeIdentifier=iossimulator-arm64 -p:EnableCodeSigning=false -p:CodesignKey= -p:CodesignProvision= -p:ProvisioningType=automatic。emulator-5554,启动 OneGate,并通过真实 UI 操作验证了地址簿列表、联系人详情、聚焦后的收款人建议、选择后的收款人预览和收款人选择弹窗。SQLitePCLRaw.lib.e_sqlite3*NU1903警告;这些包安全公告不是本 PR 新增的。