fix(claude): install managed CLI directly from source card - #16
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (16)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe changes preserve explicit CLI source selections, report whether Claude’s managed installation exists, and add a settings action to install it. They also update model-picker tests and make preferences tests wait for asynchronously rendered elements. ChangesManaged Claude installation
Codex model picker tests
Asynchronous preferences tests
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
actor User
participant ClaudeManagedInstallButton
participant install_claude_cli
participant Preferences
User->>ClaudeManagedInstallButton: Click install
ClaudeManagedInstallButton->>install_claude_cli: Install latest version
install_claude_cli-->>ClaudeManagedInstallButton: Return installation result
ClaudeManagedInstallButton->>Preferences: Set claude_cli_source to jean after success
ClaudeManagedInstallButton-->>User: Report result and installation progress
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The managed-install flow has no identified issue requiring a fix before merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 55.56% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 13 files. (3 skipped: 3 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Verification
bun run check:allin a Docker Rust/Bun quality container.jean:devfrom the final production changes.Test-suite repairs
Separate test-only changes fix pre-existing async status races and remove live CDN dependency from model-picker tests. Behavior assertions remain intact.
Manual smoke test
The Dockerfile's CLI pin is intentionally unchanged. No user preferences or running user containers were changed during verification.
Summary by CodeRabbit
New Features
Bug Fixes