Skip to content

Mount slurm-scripts to nodesets worker - #2715

Open
andriishestakov wants to merge 1 commit into
nebius:mainfrom
andriishestakov:nodesets-slurm-scripts
Open

Mount slurm-scripts to nodesets worker#2715
andriishestakov wants to merge 1 commit into
nebius:mainfrom
andriishestakov:nodesets-slurm-scripts

Conversation

@andriishestakov

Copy link
Copy Markdown
Contributor

Mount %s-slurm-scripts configmap to worker if cluster name is set

@Uburro

Uburro commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

@andriishestakov I understand the problem, but ...

The injected entries are unconditional and unguarded. If a NodeSet's values already contain a mount named slurm-scripts at /opt/slurm_scripts, the rendered pod gets duplicate volume names and duplicate mountPaths. Both rejected by API validation (must be unique), so the StatefulSet never rolls.

CM naming duplicated across charts, and not identically. slurm-cluster computes it as default .Chart.Name .Values.clusterName | trunc 63 | trimSuffix "-" + -slurm-scripts. The new helper skips both the .Chart.Name fallback and the trunc 63, so an empty or >63-char clusterName produces divergent names (silent no-mount, or a reference to a CM that doesn't exist → pods stuck in ContainerCreating). An explicit slurmScriptsConfigMapName value that defaults to the convention would decouple the two charts.

@Uburro Uburro added the helm Functional changes in Helm charts label Jul 27, 2026
@andriishestakov
andriishestakov force-pushed the nodesets-slurm-scripts branch from 08bcc5a to 0fe8dd2 Compare July 27, 2026 13:00
@andriishestakov

Copy link
Copy Markdown
Contributor Author

Added checks for slurm-cluster and nodesets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

helm Functional changes in Helm charts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants