Skip to content

Add pair_mode column to tasmanian output (read vs insert) - #77

Open
aerijman wants to merge 2 commits into
masterfrom
tasmanian_pair_mode_column
Open

aerijman wants to merge 2 commits into
masterfrom
tasmanian_pair_mode_column

Conversation

@aerijman

Copy link
Copy Markdown
Contributor

Adds pair_mode column to tasmanian output, distinguishing read vs insert level positional counts.

@aerijman
aerijman requested review from bwlang and a lite review from Copilot September 15, 2026 12:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Critical integration and failure-handling issues, plus output, resource, and test contract problems, remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR adds read- and insert-level Tasmanian positional counts with a pair_mode column.

Changes:

  • Runs Tasmanian in read and insert modes.
  • Combines results into a TSV with mode labels.
  • Updates dependencies, inputs, and process configuration.
File summaries
File Review findings
modules/tasmanian.nf Critical (3): Required inputs are not wired correctly; the FAI is passed as a mask bedgraph. Output emit name mismatches the caller. Failures may be masked by disabled error propagation. Moderate (3): process_low lacks a configured selector. Moderate (2): Publication and filename changes break the existing output contract. Nit (1): Tests do not validate the new pair_mode values.
Review details

Suppressed comments (1)

modules/tasmanian.nf:45

  • The new read/insert merge is not covered by the existing nf-tests: they still look for *.tasmanian.csv and only assert file existence, rather than checking the new header and read/insert values. Update both test cases and snapshots to the .tsv path and assert representative rows contain the new pair_mode values, otherwise this behavior can regress unnoticed.
	head -n1 ${library}.tasmanian.read.tsv | awk '{print $0"\tpair_mode"}' > ${library}.tasmanian.tsv 
	tail -n +2 ${library}.tasmanian.read.tsv | awk '{print $0"\tread"}' >> ${library}.tasmanian.tsv
	tail -n +2 ${library}.tasmanian.insert.tsv | awk '{print $0"\tinsert"}' >> ${library}.tasmanian.tsv
  • Files reviewed: 1/1 changed files
  • Comments generated: 5
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread modules/tasmanian.nf
Comment on lines +10 to +11
each path(reference_fasta)
each path (masked_bedgraph)
Comment thread modules/tasmanian.nf

output:
tuple val(library), path("${library}.tasmanian.csv"), emit: for_agg
tuple val(library), path("${library}.tasmanian.tsv"), emit: tasmanian_for_aggregate
Comment thread modules/tasmanian.nf
Comment on lines 20 to 21
set +e
set +o pipefail
Comment thread modules/tasmanian.nf
maxRetries 1
memory { task.attempt > 1 ? '16 GB' : '8 GB' }
tag "${library}"
label 'process_low'
Comment thread modules/tasmanian.nf

output:
tuple val(library), path("${library}.tasmanian.csv"), emit: for_agg
tuple val(library), path("${library}.tasmanian.tsv"), emit: tasmanian_for_aggregate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants