Repository navigation
Release the wrapper when Open fails - #437
Closed
eric-hubbard wants to merge 1 commit into
Closed
eric-hubbard wants to merge 1 commit into
eric-hubbard wants to merge 1 commit into
Conversation
newConn relied on the deferred Conn.Close to clean up when sqlite3_open_v2 fails, but Close returns early when there is no handle, so the wrapper and its linear memory were never released. Fixes ncruces#436
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #436.
newConnrelied on the deferredc.Close()to clean up whensqlite3_open_v2fails, butConn.Closereturns early whenc.handle == 0, soc.wrp.Close()was never reached and each failed open leaked the connection's linear memory (a 256 MiBPROT_NONEreservation plus the committed initial pages).The defer now closes the wrapper directly when there is no handle.
Conn.Closeis left as-is so closing a connection twice stays a no-op.TestConn_Open_notfound_leak(Linux only, not parallel) counts/proc/self/mapsentries across 20 failed opens. Without the fix it fails withmappings grew from 58 to 98 after 20 failed opens; with it, the count is flat.go test . ./tests/ ./driver/...passes on linux/amd64 and darwin/arm64.