Repository navigation
ci: build workspace packages before tests (round-trip fix) - #60
Closed
nbkdoesntknowcoding wants to merge 1 commit into
Closed
nbkdoesntknowcoding wants to merge 1 commit into
nbkdoesntknowcoding wants to merge 1 commit into
Conversation
Follow-up to #59. That PR was merged with only its first commit; the workspace-build step from the later commits didn't make it in, so the three round-trip steps still fail on main with: "Failed to load url @boppl/schema/node ... Does the file exist?" The round-trip tests import @boppl/schema/node (src/tests/round-trip/ helpers.ts). Its "./node" export resolves to ./dist/node.js, which only exists after building the package. A clean CI checkout has no dist/. Added the missing "Build workspace packages" step (pnpm -r --filter "./packages/**" build, mirroring CONTRIBUTING step 2) right after install. Verified locally: deleting packages/{schema,shared}/dist reproduces the exact failure; after the build step the three round-trip steps pass — corpus 51, fuzz 30, full-stack 2. The tests are NOT skipped or quarantined; the fix is the build step. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: nbkdoesntknowcoding <nischaybk@theboringpeople.in>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #59
PR #59 turned the
Testcheck green through the pnpm-setup / env / migration-journal fixes, but it was merged with only its first commit — the workspace-build commit that landed on the branch afterward didn't make it into the squash. As a result the three round-trip steps still fail onmain:Root cause
The round-trip tests import
@boppl/schema/node. That subpath export resolves topackages/schema/dist/node.js, which only exists after the package is built. The workflow installs deps but never builds the workspace libs, and a clean CI checkout has nodist/.Fix (single step — tests are NOT skipped or quarantined)
Added a
Build workspace packagesstep right after install, mirroring CONTRIBUTING step 2:This produces
packages/schema/dist/node.js(+@boppl/shared) so vitest can resolve the import. The three round-trip steps stay gating (nocontinue-on-error).Local verification
packages/{schema,shared}/distreproduces the exact CI failure.With this, all 13 test steps in
Testpass;typecheck/lintremain the onlycontinue-on-errorsteps (pre-existing, unrelated — documented in #59).🤖 Generated with Claude Code