Skip to content

Auto install angular LSP and services - #101

Closed
rui-monte wants to merge 16 commits into
nathansbradshaw:mainfrom
rui-monte:main
Closed

rui-monte wants to merge 16 commits into
nathansbradshaw:mainfrom
rui-monte:main

Conversation

@rui-monte

Copy link
Copy Markdown

Disclaimer:
I fully used AI for this MR. I don't have enough knowledge with rust and this LSP integrations. Fill free to reject

Motivation
Moving from VSCode to Zed was pain, mostly regarding this extension, was not a simpler install and go.

Trigger
Recently, I noticed some extensions perform installations of the LSP, so I rush have the same experience on this extension that is literally useful for my work.

This way you don't need to add the Angular LSP/Service to your project and is fully downloaded to the Zed.

I performed the test on the project, Angular 21, and was working super well.

@jpike88

jpike88 commented Sep 13, 2026 •

Copy link
Copy Markdown
Collaborator

Rejecting on the basis that the PR author doesn't understand the langauage that he submitted a PR in. Additionally, the agent decided to randomly modify/reword comments and funciton names, write comments that are extremely diffcult for a human to make sense of, shuffle variable declarations, as well as fail to follow the configuration object pattern already established.

The entire point of having users manage their own language server version is that it is pinned to their project's angular version, as misalignment between those creates all kinds of bugs that then mistakenly assumed to be the fault of this extension. Earlier versions of this extension tried to self manage the langue server (like this PR looks like it tries to do), and we, the maintainers, would get issues complaining about problems that were simply due to version misalignment.

Additionally, not trying to talk to npm removes the need for the IDE to have to talk to npm at all, allowing for a offline capable extension. Its behaviour is simple and reliable.

If you would have looked at previous versions of the extension you would have noticed all this. Please avoid just vibe coding your way across repos, it doesn't help the way you think it does.

@jpike88 jpike88 closed this Sep 13, 2026
@jpike88

jpike88 commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

#102

This pr has been opened to make it clear that bringing your own language server is a deliberate design decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants