Repository navigation
Prevent PUT /cameras/{id} rename from overwriting a different camera - #5
Merged
Merged
Conversation
PUT /cameras/{id} with a body camera_id different from the path treats it
as a rename: it deletes the old file and writes the new id. It never checked
whether that new id already belonged to a different camera, so a rename onto
an existing id silently deleted and overwrote that camera's config.
Guard the rename branch: if the destination id already exists, return 409
and change nothing. Adds tests for the collision (both cameras survive) and
the happy-path rename to a free id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PUT /cameras/{id}treats a bodycamera_iddifferent from the path as a rename (delete old file, write new id). It never checked whether the destination id already belonged to a different camera, soPUT /cameras/Awith bodycamera_id: Bsilently deleted and overwrote camera B's config. This guards the rename branch: if the destination id already exists, return409and change nothing.Related Issue
N/A
Motivation and Context
Silent data-loss / integrity bug: a rename could destroy an unrelated camera's calibration with no error returned. Renames to a free id, and normal in-place updates, are unaffected.
How Has This Been Tested?
Types of changes
Checklist:
ruff checkandruff formatpass)