Repository navigation
Update PassiveRateGroup to push initial values for channels - #6382
Open
bevinduckett wants to merge 1 commit into
Open
bevinduckett wants to merge 1 commit into
bevinduckett wants to merge 1 commit into
Conversation
LeStarch
approved these changes
Nov 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Svc::PassiveRateGroup::configure()now writes an initial value for each of the component's telemetry channels:MaxCycleTime(current value of the max-time tracker)CycleTime(0)CycleCount(current cycle count)PortCycleTimeHWM(current per-port high water marks; only whenPassiveRateGroupCfg::PortCycleTimeis enabled)The
configure()header comment anddocs/sdd.mdare updated to say that these writes happen, and that the telemetry and time ports must be connected beforeconfigure()is called for the writes to be delivered.A new unit test,
InitialTelemetry(test case 101.5.1,runInitialTlmTest), callsconfigure()after the ports are connected and checks that each channel has exactly one initial value before any cycle runs.Rationale
Before this change, a rate group channel had no value until its first cycle completed. Channels like
PortCycleTimeHWMandMaxCycleTimecould therefore be missing from telemetry for a ground system or downstream consumer that reads them right after startup. Writing initial values inconfigure()means every channel has a defined value from the start.Testing/Review Recommendations
Svc/PassiveRateGroupunit tests (fprime-util checkinSvc/PassiveRateGroup), including the newInitialTelemetrytest. (The author of this draft did not run them.)configure()runs. Deployments that callconfigure()before connecting ports will silently not emit these values. The firstconfigure()in the existing unit test fixture runs before the ports are connected, so the new test callsconfigure()a second time.tlmWrite_*calls are acceptable at theconfigure()call site in existing topologies, in particular the ordering relative to port connection and time-port availability.Future Work
None planned.
Contributor Checklist
AI Usage (see policy)
Claude Sonnet was used to update the unit test and SDD. It was also used to run the review skills from fprime and summarize the PR changes.
AGENTS.md).