Repository navigation
Conversation
The schedIn handler was an empty TODO, yet the async port could still assert on a full queue. Remove the port, its handler, the SDD row, and the unit-test connection. Co-authored-by: M Starch <LeStarch@googlemail.com>
Coverage report — base
|
| Module | Line | Δ | Function | Δ | Branch | Δ |
|---|---|---|---|---|---|---|
Os/Generic/Types |
91.79 | -0.35 | 92.86 | +0.00 | 73.83 | +0.00 |
Os/Generic |
90.28 | +0.20 | 89.13 | +0.00 | 75.48 | +0.58 |
Fw/DataStructures |
98.04 | +0.44 | 97.14 | +0.00 | 82.85 | +0.73 |
Svc/BufferLogger |
94.97 | +1.18 | 100.00 | +4.35 | 78.10 | +0.00 |
New modules
| Module | Line | Function | Branch |
|---|---|---|---|
Fw/Prm |
0.00 | 0.00 | 0.00 |
Modules without UTs
CFDP/Checksum/GTest, Drv/LinuxGpioDriver, Drv/LinuxI2cDriver, Drv/LinuxSpiDriver, Drv/Ports/DataTypes, Drv/PosixUartDriver, FppTestProject/FppTest/topology/async, FppTestProject/FppTest/topology/components/Comp, FppTestProject/FppTest/topology/components/Framework, FppTestProject/FppTest/topology/components/Receiver, FppTestProject/FppTest/topology/components/Sender, FppTestProject/FppTest/topology/guarded, FppTestProject/FppTest/topology/sync, FppTestProject/FppTest/topology/top_ports, FppTestProject/FppTest/topology/types, Fw/Com, Fw/Comp, Fw/FilePacket/GTest, Fw/Fpy, Fw/Obj, Fw/Port, Fw/Sm, Fw/Test, Fw/Types/GTest, Os/Models, Svc/Ccsds/Types, Svc/Ccsds/Utils, Svc/FatalHandler, Svc/Subtopologies/CdhCore, Svc/Subtopologies/ComCcsds, Svc/Subtopologies/ComCcsdsSdls, Svc/Subtopologies/ComFprime, Svc/Subtopologies/ComLoggerTee, Svc/Subtopologies/DataProducts, Svc/Subtopologies/DpCompression, Svc/Subtopologies/FileHandling, Svc/Subtopologies/FileHandlingCfdp, Svc/Subtopologies/FileHandlingCfdp/FileHandlingCfdpConfig, TestDeploymentsProject/Ref/DpDemo, TestDeploymentsProject/Ref/PingReceiver, TestDeploymentsProject/Ref/RecvBuffApp, TestDeploymentsProject/Ref/SendBuffApp, TestDeploymentsProject/Ref/Top, TestDeploymentsProject/Ref/TypeDemo, cmake/test/data/TestConfigDeployment, cmake/test/data/TestDeployment/TestBuildAutocoder, cmake/test/data/TestDeployment/TestDuplicateDirective, cmake/test/data/TestDeployment/TestHeaderAutocoder, cmake/test/data/TestDeployment/TestLinkDepends, cmake/test/data/TestDeployment/TestRelative, cmake/test/data/test-fprime-library/TestLibrary/TestComponent, cmake/test/data/test-fprime-library2/TestLibrary2/TestComponent
|
@thomas-bc @LeStarch This PR is already labeled Release NotesUser Breaking Changes
|
Change Description
Removes the
schedInport fromSvc.BufferLogger:- async input port schedIn: Svc.Schedalong with
BufferLogger::schedIn_handler, the SDD port-table row, and the unit-test connection.Breaking change: a topology that connects a rate group to
BufferLogger.schedInmust delete that connection. No topology in this repository instantiatesBufferLogger.Rationale
schedIn_handlerwas an empty// TODO. The port wasasyncwith the default queue-full behavior (assert), so a rate-group tick that does no work could stillFW_ASSERTthe component when its queue was full of logging work. #6288 applied the single-queued-message pattern from #6202 to the other components and leftBufferLoggerout; since this port does nothing, it is removed rather than converted.Testing/Review Recommendations
fprime-util checkinSvc/BufferLogger: 11 tests pass..fppoutsideSvc/BufferLoggerreferences the component.Future Work
None.
Contributor Checklist
AI Usage (see policy)
Devin (Cognition) audited #6202 against
devel, made the change, and ran the unit tests, at the direction of M Starch, who chose removal over conversion.AGENTS.md).IAMAI