Skip to content

Svc/BufferLogger: remove unused schedIn port - #6370

Merged
LeStarch merged 1 commit into
nasa:develfrom
lestarch-autobot:devin/1794266350-bufferlogger-remove-schedin
Nov 11, 2026
Merged

LeStarch merged 1 commit into
nasa:develfrom
lestarch-autobot:devin/1794266350-bufferlogger-remove-schedin

Conversation

@lestarch-autobot

Copy link
Copy Markdown
Collaborator
Related Issue(s) #6202
Has Unit Tests (y/n) y (existing suite passes; no new tests)
Documentation Included (y/n) y (SDD port table)
Generative AI was used in this contribution (y/n) AI

Change Description

Removes the schedIn port from Svc.BufferLogger:

-    async input port schedIn: Svc.Sched

along with BufferLogger::schedIn_handler, the SDD port-table row, and the unit-test connection.

Breaking change: a topology that connects a rate group to BufferLogger.schedIn must delete that connection. No topology in this repository instantiates BufferLogger.

Rationale

schedIn_handler was an empty // TODO. The port was async with the default queue-full behavior (assert), so a rate-group tick that does no work could still FW_ASSERT the component when its queue was full of logging work. #6288 applied the single-queued-message pattern from #6202 to the other components and left BufferLogger out; since this port does nothing, it is removed rather than converted.

Testing/Review Recommendations

  • fprime-util check in Svc/BufferLogger: 11 tests pass.
  • No deployment was built: no .fpp outside Svc/BufferLogger references the component.

Future Work

None.

Contributor Checklist

AI Usage (see policy)

Devin (Cognition) audited #6202 against devel, made the change, and ran the unit tests, at the direction of M Starch, who chose removal over conversion.

IAMAI

The schedIn handler was an empty TODO, yet the async port could still assert on a full queue. Remove the port, its handler, the SDD row, and the unit-test connection.

Co-authored-by: M Starch <LeStarch@googlemail.com>
@lestarch-autobot lestarch-autobot added the Breaking Changes / Needs Release Notes Need to add instructions in the release notes for updates. label Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Coverage report — base devel

Overall (line): 85.92% → 85.94% (+0.02)
Regression threshold: 0.50% (line).

Regressions

(none over threshold)

Modules changed

Module Line Δ Function Δ Branch Δ
Os/Generic/Types 91.79 -0.35 92.86 +0.00 73.83 +0.00
Os/Generic 90.28 +0.20 89.13 +0.00 75.48 +0.58
Fw/DataStructures 98.04 +0.44 97.14 +0.00 82.85 +0.73
Svc/BufferLogger 94.97 +1.18 100.00 +4.35 78.10 +0.00

New modules

Module Line Function Branch
Fw/Prm 0.00 0.00 0.00

Modules without UTs

CFDP/Checksum/GTest, Drv/LinuxGpioDriver, Drv/LinuxI2cDriver, Drv/LinuxSpiDriver, Drv/Ports/DataTypes, Drv/PosixUartDriver, FppTestProject/FppTest/topology/async, FppTestProject/FppTest/topology/components/Comp, FppTestProject/FppTest/topology/components/Framework, FppTestProject/FppTest/topology/components/Receiver, FppTestProject/FppTest/topology/components/Sender, FppTestProject/FppTest/topology/guarded, FppTestProject/FppTest/topology/sync, FppTestProject/FppTest/topology/top_ports, FppTestProject/FppTest/topology/types, Fw/Com, Fw/Comp, Fw/FilePacket/GTest, Fw/Fpy, Fw/Obj, Fw/Port, Fw/Sm, Fw/Test, Fw/Types/GTest, Os/Models, Svc/Ccsds/Types, Svc/Ccsds/Utils, Svc/FatalHandler, Svc/Subtopologies/CdhCore, Svc/Subtopologies/ComCcsds, Svc/Subtopologies/ComCcsdsSdls, Svc/Subtopologies/ComFprime, Svc/Subtopologies/ComLoggerTee, Svc/Subtopologies/DataProducts, Svc/Subtopologies/DpCompression, Svc/Subtopologies/FileHandling, Svc/Subtopologies/FileHandlingCfdp, Svc/Subtopologies/FileHandlingCfdp/FileHandlingCfdpConfig, TestDeploymentsProject/Ref/DpDemo, TestDeploymentsProject/Ref/PingReceiver, TestDeploymentsProject/Ref/RecvBuffApp, TestDeploymentsProject/Ref/SendBuffApp, TestDeploymentsProject/Ref/Top, TestDeploymentsProject/Ref/TypeDemo, cmake/test/data/TestConfigDeployment, cmake/test/data/TestDeployment/TestBuildAutocoder, cmake/test/data/TestDeployment/TestDuplicateDirective, cmake/test/data/TestDeployment/TestHeaderAutocoder, cmake/test/data/TestDeployment/TestLinkDepends, cmake/test/data/TestDeployment/TestRelative, cmake/test/data/test-fprime-library/TestLibrary/TestComponent, cmake/test/data/test-fprime-library2/TestLibrary2/TestComponent

@LeStarch
LeStarch merged commit 2259dab into nasa:devel Nov 11, 2026
88 of 89 checks passed
@thomas-bc-autowot

Copy link
Copy Markdown
Collaborator

@thomas-bc @LeStarch This PR is already labeled Breaking Changes / Needs Release Notes; suggested entry: topologies that connect a rate group to BufferLogger.schedIn must delete that connection, because the port no longer exists.

Release Notes

User Breaking Changes

Svc.BufferLogger schedIn port removed

The unused schedIn port (an empty handler) has been removed from Svc.BufferLogger. Deployments with any connection to bufferLogger.schedIn (typically from a rate group) must remove it; the freed rate group output can be left unconnected.

-    rateGroup1.RateGroupMemberOut[N] -> bufferLogger.schedIn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking Changes / Needs Release Notes Need to add instructions in the release notes for updates.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants