Skip to content

ci: reach the cFS reference through the cfs-lab GDS plugins - #6338

Merged
LeStarch merged 1 commit into
nasa:develfrom
lestarch-autobot:ext-cfs-reference-cfs-lab-gds
Nov 6, 2026
Merged

LeStarch merged 1 commit into
nasa:develfrom
lestarch-autobot:ext-cfs-reference-cfs-lab-gds

Conversation

@lestarch-autobot

Copy link
Copy Markdown
Collaborator
Related Issue(s) fprime-community/fprime_cfs_reference#44 (retired the fprime_gds bridge app); failing nightly https://github.com/nasa/fprime/actions/runs/42294344110
Has Unit Tests (y/n) n (CI workflow change; verified by this PR's own External Repo: cFS Reference run)
Documentation Included (y/n) n/a
Generative AI was used in this contribution (y/n) AI

Change Description

ext-fprime-cfs-reference.yml launched fprime-gds --ip-client --ip-port 15010, the TCP port of the fprime_gds bridge app that fprime-community/fprime_cfs_reference#44 removed on 2026-11-05. The reference FSW now talks to the ground only through CI_LAB/TO_LAB, reached with the cfs-lab communication plugin and cfs framing plugin from the fprime_cfs Python package. This PR switches gds-args to --communication-selection cfs-lab --framing-selection cfs, matching the reference repository's own build-and-test.yml.

Rationale

Every External Repo: cFS Reference run since the #44 merge fails: the comm.py.log artifact shows the GDS retrying Connection refused on 0.0.0.0:15010 for the whole run while FSW starts normally (CI_LAB listening on UDP port: 1234), so all 9 integration tests time out with no events or telemetry. The failure shows up as a red check on every open PR (e.g. #6336) and on the nightly schedule.

Testing/Review Recommendations

  • The External Repo: cFS Reference job on this PR is the test. The fprime-cfs plugin package is already installed by external-repository-setup from the target's requirements.txt (./libs/fprime_cfs/python), so no further workflow change is needed.
  • Compare with fprime-community/fprime_cfs_reference .github/workflows/build-and-test.yml (green on devel).

Future Work

None.

Contributor Checklist

AI Usage (see policy)

An AI agent (Devin) diagnosed the failure from the job log and gds-logs artifact, made the one-line workflow change, and wrote this description at the request of @LeStarch.

IAMAI

fprime_cfs_reference#44 retired the fprime_gds TCP bridge app; the GDS now
connects through CI_LAB/TO_LAB with the fprime_cfs cfs-lab communication and
cfs framing plugins (already installed by the target's requirements.txt).
The external-repo workflow still pointed fprime-gds at TCP 15010, so every
integration test timed out with no telemetry.

Co-authored-by: M Starch <LeStarch@googlemail.com>
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Coverage report — base devel

Overall (line): 85.94% → 85.93% (-0.01)
Regression threshold: 0.50% (line).

Regressions

(none over threshold)

Modules changed

Module Line Δ Function Δ Branch Δ
Fw/DataStructures 98.04 +0.35 97.14 +0.00 82.85 +0.55
Os/Generic/Types 92.14 +0.35 92.86 +0.00 73.83 -0.94
Os/Posix 71.03 +0.39 87.50 +0.00 50.89 +0.22

New modules

Module Line Function Branch
Fw/Prm 0.00 0.00 0.00

Modules without UTs

CFDP/Checksum/GTest, Drv/LinuxGpioDriver, Drv/LinuxI2cDriver, Drv/LinuxSpiDriver, Drv/Ports/DataTypes, Drv/PosixUartDriver, FppTestProject/FppTest/topology/async, FppTestProject/FppTest/topology/components/Comp, FppTestProject/FppTest/topology/components/Framework, FppTestProject/FppTest/topology/components/Receiver, FppTestProject/FppTest/topology/components/Sender, FppTestProject/FppTest/topology/guarded, FppTestProject/FppTest/topology/sync, FppTestProject/FppTest/topology/top_ports, FppTestProject/FppTest/topology/types, Fw/Com, Fw/Comp, Fw/FilePacket/GTest, Fw/Fpy, Fw/Obj, Fw/Port, Fw/Sm, Fw/Test, Fw/Types/GTest, Os/Models, Svc/Ccsds/Types, Svc/Ccsds/Utils, Svc/FatalHandler, Svc/Subtopologies/CdhCore, Svc/Subtopologies/ComCcsds, Svc/Subtopologies/ComCcsdsSdls, Svc/Subtopologies/ComFprime, Svc/Subtopologies/ComLoggerTee, Svc/Subtopologies/DataProducts, Svc/Subtopologies/DpCompression, Svc/Subtopologies/FileHandling, Svc/Subtopologies/FileHandlingCfdp, Svc/Subtopologies/FileHandlingCfdp/FileHandlingCfdpConfig, TestDeploymentsProject/Ref/DpDemo, TestDeploymentsProject/Ref/PingReceiver, TestDeploymentsProject/Ref/RecvBuffApp, TestDeploymentsProject/Ref/SendBuffApp, TestDeploymentsProject/Ref/Top, TestDeploymentsProject/Ref/TypeDemo, cmake/test/data/TestConfigDeployment, cmake/test/data/TestDeployment/TestBuildAutocoder, cmake/test/data/TestDeployment/TestDuplicateDirective, cmake/test/data/TestDeployment/TestHeaderAutocoder, cmake/test/data/TestDeployment/TestLinkDepends, cmake/test/data/TestDeployment/TestRelative, cmake/test/data/test-fprime-library/TestLibrary/TestComponent, cmake/test/data/test-fprime-library2/TestLibrary2/TestComponent

@LeStarch
LeStarch merged commit 5facbe0 into nasa:devel Nov 6, 2026
85 checks passed
@thomas-bc-autowot thomas-bc-autowot added the CI Issues pertaining to Continuous Integration label Nov 7, 2026
github-actions Bot added a commit that referenced this pull request Nov 7, 2026
github-actions Bot added a commit that referenced this pull request Nov 7, 2026
github-actions Bot added a commit that referenced this pull request Nov 7, 2026
github-actions Bot added a commit that referenced this pull request Nov 7, 2026
github-actions Bot added a commit that referenced this pull request Nov 8, 2026
github-actions Bot added a commit that referenced this pull request Nov 8, 2026
github-actions Bot added a commit that referenced this pull request Nov 8, 2026
github-actions Bot added a commit that referenced this pull request Nov 8, 2026
github-actions Bot added a commit that referenced this pull request Nov 9, 2026
github-actions Bot added a commit that referenced this pull request Nov 9, 2026
github-actions Bot added a commit that referenced this pull request Nov 9, 2026
github-actions Bot added a commit that referenced this pull request Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Issues pertaining to Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants