Skip to content

Purge fpp-to-json - #1127

Open
Kronos3 wants to merge 12 commits into
mainfrom
purge-json
Open

Purge fpp-to-json#1127
Kronos3 wants to merge 12 commits into
mainfrom
purge-json

Conversation

@Kronos3

@Kronos3 Kronos3 commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Removes fpp-to-json
  • Keeps fpp-to-json in the pyproject.toml which now routes to an error message about not being supported anymore.
  • Moved AstJsonEncoder -> test only to support TemplatesSpec tests

Closes #1112

@Kronos3

Kronos3 commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author
Screenshot 2026-09-24 at 12 35 01 PM

... I forgot about this dependency. Currently, the TemplateSpec tests validate that the AST is DEEPLY cloned by an expansion by converting it to JSON and then validating that all node IDs are unique. We may have to keep around the AST -> JSON values purely for this check (only build/test-time not runtime).

@Kronos3
Kronos3 requested a review from bocchino September 24, 2026 21:21
@bocchino

bocchino commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

Removes JVM from release wheels

I think it means that FPP will no longer work on Intel Mac, because the native build is not supported there. @LeStarch please weigh in here. Do we still need to support Intel Mac?

@bocchino

bocchino commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

After discussion with @LeStarch, we will need to keep the JVM wheels. We can decouple the JVM unit tests from per-PR CI, but we will need some other way to run them, e.g., nightly or just before a release.

@bocchino

bocchino commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@Kronos3 can we narrow the scope of this PR so that it just removes fpp-to-json and does not revise the wheels or the unit tests? I think that is sufficient to address #1112, and it can be merged as soon as it is done. I think we should treat unit test optimization as a separate issue. Also, some more CI work seems to be required to support the UT optimization. So I think that work should be tracked as a separate issue.

bocchino
bocchino requested changes Sep 28, 2026
View reviewed changes

@bocchino bocchino left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes as described in the comments.

Kronos3 added 4 commits October 6, 2026 16:16
@Kronos3
Narrow scope: keep JVM/jar wheels and compiler test CI
cacd51a 
Per PR #1127 review feedback, this PR should only remove fpp-to-json.
Restore the JVM/JAR fallback in release wheels and the compiler './test'
CI step; both are tracked as separate follow-up issues (see
remove-jar-wheels and remove-compiler-test-ci branches).
@Kronos3
Merge remote-tracking branch 'origin/main' into purge-json
57524eb 
# Conflicts:
#	compiler/tools/fpp-to-json/test/importedTopologies.ref.txt
#	compiler/tools/fpp-to-json/test/patternedConnections.ref.txt
#	compiler/tools/fpp-to-json/test/ports.ref.txt
#	compiler/tools/fpp-to-json/test/simpleTopology.ref.txt
#	compiler/tools/fpp-to-json/test/telemetry.ref.txt
#	compiler/tools/fpp-to-json/test/telemetryPackets.ref.txt
#	compiler/tools/fpp-to-json/test/templateSystem.ref.txt
#	docs/fpp-spec.html
#	docs/fpp-users-guide.html
#	docs/index.html
@Kronos3
Merge remote-tracking branch 'origin/main' into purge-json
2e03e9c
@Kronos3
Merge remote-tracking branch 'origin/main' into purge-json
acabe5d
@Kronos3
Kronos3 requested a review from bocchino October 7, 2026 16:02
@bocchino

bocchino commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Looks good! Can you synchronize with main and make the corresponding updates to the wiki?

Kronos3 and others added 3 commits October 12, 2026 14:35
@Kronos3
Merge remote-tracking branch 'origin/main' into purge-json
b961297 
# Conflicts:
#	compiler/tools/fpp/src/main/scala/fpp-to-json.scala
#	docs/fpp-spec.html
#	docs/fpp-users-guide.html
@Kronos3
Remove fpp-to-json from docs/wiki
31ec7aa 
Drops the fpp-to-json wiki page and its references in Tools and
Adding-New-Features-to-FPP, which were reintroduced by the merge
from origin/main.
@bocchino
Revise Adding New Features
4eaa368
@bocchino bocchino added the fprime-fpp tandem F Prime and FPP tandem development label Oct 13, 2026
@bocchino

bocchino commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator

This PR looks good to me on the FPP side. Since it is removing a feature that F Prime depends on, we need to treat this as a tandem PR: make an alpha release, integrate, and pass CI before merging.

@Kronos3 Kronos3 added the blocked Issue is blocked pending resolution of another issue label Oct 14, 2026
bocchino
bocchino approved these changes Oct 15, 2026
View reviewed changes

@bocchino bocchino left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of this PR looks good, so I'll approve it. The blocked and tandem labels record what we still have to do before merging it.

@bocchino bocchino removed the blocked Issue is blocked pending resolution of another issue label Nov 4, 2026
@Kronos3 Kronos3 mentioned this pull request Nov 6, 2026
Open
3 tasks done

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bocchino bocchino bocchino approved these changes

Assignees

No one assigned

Labels

fprime-fpp tandem F Prime and FPP tandem development

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove fpp-to-json

2 participants

@Kronos3 @bocchino