Fix cFS DoS via Unvalidated AppEntryPoint#2685
Open
aw0lid wants to merge 1 commit into
Open
Conversation
bf87ddd to
16f5514
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request addresses the Denial of Service (DoS) vulnerability reported in #2684. It adds a validation layer within
CFE_ES_AppCreateto ensure that the requestedAppEntryPoint(symbol name) is not already in use by any active application or core service.Fix Logic
The fix implements a two-tier validation strategy for the
AppEntryPoint:CFE_orOS_). This prevents external apps from attempting to reuse core system symbols.AppTablewhile holding theSharedDatalock to verify if the providedInitSymbolNameis already in use by another running application.This ensures the system rejects unauthorized or conflicting entry points before resource allocation, preventing OSAL mutex name collisions and fatal system aborts (SIGABRT).
Testing Performed
Verified on cFS Draco (v7.0.0).
CFE_ES_START_APP_CCpackets.AppEntryPointset toCFE_ES_Main.AppEntryPointset toSCH_LAB_AppMain(already running).CFE_ES_ERR_DUPLICATE_NAME.Impact
Closes #2684