Skip to content

chore(ensrainbow.io): Update FullRainbow component values and footnote for clarity#2203

Merged
lightwalker-eth merged 11 commits into
mainfrom
fix-ensrainbow-coverage
May 28, 2026
Merged

chore(ensrainbow.io): Update FullRainbow component values and footnote for clarity#2203
lightwalker-eth merged 11 commits into
mainfrom
fix-ensrainbow-coverage

Conversation

@djstrong
Copy link
Copy Markdown
Member

@djstrong djstrong commented May 26, 2026

Lite PR

Summary

  • Refined the design of the Get the full rainbow section on ensrainbow.io

Why


Testing

  • Verified the UI after introducing changes using a local and Vercel (build) previews

Notes for Reviewer (Optional)

  • Pure UI/UX changes, so I don't think that the changeset log is required

Pre-Review Checklist (Blocking)

  • This PR does not introduce significant changes and is low-risk to review quickly.
  • Relevant changesets are included (or are not required)

Copilot AI review requested due to automatic review settings May 26, 2026 20:08
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
enskit-react-example.ensnode.io Ready Ready Preview, Comment May 28, 2026 2:53pm
ensnode.io Ready Ready Preview, Comment May 28, 2026 2:53pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
admin.ensnode.io Skipped Skipped May 28, 2026 2:53pm
ensrainbow.io Skipped Skipped May 28, 2026 2:53pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 26, 2026

⚠️ No Changeset found

Latest commit: 1392485

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Refactors BarChart rendering/layout (percent computation, external percent label, rainbow fill width transition) and updates FullRainbow BarChart dataset: "ENS Subgraph" set to 11, "Current" and "Target" bar values/gradients adjusted (Target replaces Future target and includes ENSRainbowBeam), and footnote expanded to note encoded labelhashes for unnormalized names.

Changes

ENS Rainbow Chart Updates

Layer / File(s) Summary
BarChart rendering and layout refactor
docs/ensrainbow.io/src/components/molecules/BarChart.tsx
Rewrote data.map(...) bar loop: extracted percent/percentLabel, switched to horizontal layout with an external right-aligned percent <span>, applied rainbow fill as an absolutely positioned element with width: ${percent}%, added transition-[width], and adjusted footnote classes to include whitespace-pre-wrap.
BarChart data, label, and footnote
docs/ensrainbow.io/src/components/organisms/FullRainbow.tsx
Updated BarChart entries: "ENS Subgraph" value set to 11 with revised gradient stops; "Current" bar value and gradient stops updated; "Future target" replaced by "Target" which includes an ENSRainbowBeam label element and new value/gradient stops; footnote text extended to note unnormalized names appear as encoded labelhashes in the ENS Subgraph.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • namehash/ensnode#2195: Modifies the same FullRainbow component's BarChart data, labels, and footnote content.

Poem

🐰🌈
I hopped to tweak the rainbow bright,
Bars now march with measured light,
Eleven beams and a target gleam,
Footnote whispers about hashed-name schemes,
I nibble a carrot and celebrate the dream.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description follows the template structure with all required sections completed: Summary (1 bullet), Why (with Slack reference), Testing (local and Vercel previews), Pre-Review Checklist marked appropriately, and optional Notes section included.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and specifically describes the main changes: updating the FullRainbow component's values and footnote. It directly relates to the primary modifications in the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-ensrainbow-coverage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ENSRainbow docs “FullRainbow” chart to reflect revised coverage values and clarifies the explanatory footnote for how results are calculated.

Changes:

  • Adjusted the displayed coverage values for “ENS Subgraph”, “ENSRainbow + ENSNode (Current)”, and the target configuration.
  • Updated the target label to “ENSRainbow + ENSNode + ENSRainbowBeam” and changed the badge text from “Future target” to “Target”.
  • Expanded the footnote to clarify that certain unnormalized/encoded-labelhash formatted names are excluded from results.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings May 26, 2026 20:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@djstrong djstrong marked this pull request as ready for review May 26, 2026 20:31
@djstrong djstrong requested a review from a team as a code owner May 26, 2026 20:31
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 26, 2026

Greptile Summary

This PR refines the "Get the full rainbow" section on ensrainbow.io: the BarChart component is visually redesigned (label above the bar, percentage label moved outside to the right, footnote gains whitespace-pre-wrap), and FullRainbow updates coverage numbers, gradient colours, the third bar's label, and the footnote text.

  • BarChart.tsx: percent is now pre-computed before JSX, the bar and its label sit in a flex row, and the percentage <span> is rendered outside the bar container. whitespace-pre-wrap on the footnote enables multi-line text via embedded \n characters.
  • FullRainbow.tsx: Coverage values updated to 11 / 94 / 99 %, the third item renamed from "ENSRainbow + ENSNode Future target" to "ENSRainbowBeam + ENSNode Target", all gradient directions flipped to 270deg, and the footnote extended with a second sentence separated by &#10; (JSX decodes this to a real newline, correctly displayed by whitespace-pre-wrap).

Confidence Score: 5/5

Pure UI and data update with no logic-affecting risk — safe to merge.

All changes are confined to visual layout and static data: bar chart layout tweaks, updated coverage percentages and gradient colours, a renamed label, and an extended footnote. The entity in the JSX attribute is correctly decoded to a newline by the JSX parser, and whitespace-pre-wrap renders it as expected. No data flow, API calls, or shared logic is touched.

No files require special attention.

Important Files Changed

Filename Overview
docs/ensrainbow.io/src/components/molecules/BarChart.tsx Bar layout refactored: label moved above the bar row, percentage moved outside to the right; footnote gains whitespace-pre-wrap to support embedded newlines.
docs/ensrainbow.io/src/components/organisms/FullRainbow.tsx Coverage values updated (11/94/99%), gradient directions revised, third bar renamed to "ENSRainbowBeam + ENSNode", footnote extended with a second sentence using for a line break, and container capped at max-w-[640px].

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[FullRainbow] -->|passes data + footnote| B[BarChart]
    B --> C{data.map}
    C --> D[Compute percent = value/maxValue*100]
    D --> E[Render label span above bar row]
    E --> F[Flex row: bar container + percent label]
    F --> G[Colored bar div at percent% width]
    F --> H[Percentage span outside bar, right-aligned]
    B --> I{footnote?}
    I -->|yes| J[p.whitespace-pre-wrap renders newline from &#10;]
Loading

Reviews (8): Last reviewed commit: "Merge branch 'main' into fix-ensrainbow-..." | Re-trigger Greptile

Copilot AI review requested due to automatic review settings May 26, 2026 21:37
@vercel vercel Bot temporarily deployed to Preview – admin.ensnode.io May 26, 2026 21:37 Inactive
@vercel vercel Bot temporarily deployed to Preview – ensnode.io May 26, 2026 21:37 Inactive
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comment thread docs/ensrainbow.io/src/components/organisms/FullRainbow.tsx
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/ensrainbow.io/src/components/organisms/FullRainbow.tsx`:
- Line 44: The footnote prop in FullRainbow is using the literal entity "&`#10`;"
which will not render as a newline; replace that entity with a real newline
character and provide the string as a JS string/template (e.g.
footnote={`Coverage vs. indexing the ENS Subgraph with no rainbow tables as of
26 May, 2026.\nResults exclude unnormalized names that are formatted as encoded
labelhashes in the ENS Subgraph but are actually known.`}) so the newline is
preserved and will work with whitespace-pre-wrap.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 989152d1-7aa7-4915-9ce9-208638e2f9b0

📥 Commits

Reviewing files that changed from the base of the PR and between 3630b9f and af645a8.

📒 Files selected for processing (2)
  • docs/ensrainbow.io/src/components/molecules/BarChart.tsx
  • docs/ensrainbow.io/src/components/organisms/FullRainbow.tsx

Comment thread docs/ensrainbow.io/src/components/organisms/FullRainbow.tsx
@vercel vercel Bot temporarily deployed to Preview – ensnode.io May 28, 2026 07:26 Inactive
@vercel vercel Bot temporarily deployed to Preview – admin.ensnode.io May 28, 2026 07:26 Inactive
@Y3drk Y3drk changed the title Update FullRainbow component values and footnote for clarity chore(ensrainbow.io): Update FullRainbow component values and footnote for clarity May 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread docs/ensrainbow.io/src/components/organisms/FullRainbow.tsx
Copy link
Copy Markdown
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Y3drk @djstrong Great work here guys. Thank you 🫡

@lightwalker-eth lightwalker-eth merged commit 493b4b6 into main May 28, 2026
20 checks passed
@lightwalker-eth lightwalker-eth deleted the fix-ensrainbow-coverage branch May 28, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Docs related ensrainbow ENSRainbow related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants