chore(types): drop the removed moduleResolution=node10 from the type-check config - #179
Merged
Merged
Conversation
…check config TypeScript 7 removes moduleResolution=node10 (the "node" alias), so `tsc -p types/tsconfig.json` fails with TS5108 on the dependabot bump to 7.0.2 (#177). Use the node18 module preset instead, which implies the matching resolution and checks the `import = require()` test files the way a real CommonJS consumer resolves them. Only the type-check config changes; the published index.d.ts is untouched. Verified green on tsc 5.9.3, 6.x and 7.0.2. Signed-off-by: kurok <22548029+kurok@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot's TypeScript 5.9.3 → 7.0.2 bump (#177) fails
lint/ci-okwith:TS 7 removed
moduleResolution: "node"(thenode10alias). Onlytypes/tsconfig.jsonuses it, and onlynpm run test:typesruns it.What
Replace
module: commonjs+moduleResolution: nodewithmodule: node18, which sets the matching resolution implicitly and checks theimport X = require()test files the way a real CommonJS consumer resolves them.Compatibility
index.d.ts(export = VaultClient) is untouched; consumers on any TypeScript version see identical declarations.ignoreentry needed.Verified locally:
tsc -p types/tsconfig.jsonpasses on 5.9.3, 6.x and 7.0.2.Landing this first lets dependabot rebase #177 onto master and go green.