[Suprapote]

Description

Set Z code as PAL and update the region info link since the original is broken

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

• Improvement (non-breaking change that adds a new feature)
• Bug fix (fixes an issue)
• Breaking change (breaking change)
• Documentation Improvement
• Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

You agree with the license terms and that other license types may be granted with permission of the original N64FlashcartMenu project license holders.

• I agree.
• AI helped me.

Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>

Summary by CodeRabbit

• Bug Fixes
  • ROMs from the miscellaneous PAL market are now correctly identified as PAL instead of showing an unknown TV type.
  • Updated ROM destination labels to distinguish PAL Regional, European Regional, and PAL Miscellaneous markets.
• Documentation
  • Updated the market information reference link to point to the Ultra64 manual.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: bfbc006e-6977-4215-860f-87e06d87cad7

Commits

Reviewing files that changed from the base of the PR and between 9c94995 and 0b58729.

Files selected for processing: 2

• src/menu/rom_info.c
• src/menu/views/load_rom.c

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

The ROM loading view now uses an Ultra64 manual link and updated labels for three market codes. TV type detection now classifies MARKET_OTHER_Z as PAL.

Changes: ROM market classification

Layer / File(s)	Summary
Market labels and TV type mapping src/menu/views/load_rom.c, src/menu/rom_info.c	The loading view updates the reference link and labels for MARKET_OTHER_X, MARKET_OTHER_Y, and MARKET_OTHER_Z. TV type detection maps MARKET_OTHER_Z to PAL.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Suggested labels: bug, documentation

Suggested reviewers: networkfusion

Merge Risk: Minimal · up to 0b587

Z-coded ROMs now use PAL mode. No concrete merge-blocking risk was identified.

Architecture risk: Low · up to 0b587

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — src (service) was modified; 2 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in src/menu/rom_info.c: MARKET_OTHER_Z now shares the PAL return path; previously it fell through to the default unknown result. The comment noting uncertainty about this market was removed.
• observed — Modified behavior in src/menu/views/load_rom.c: Replaces the TODO and PAL submission-documentation reference with a link to the Ultra64 manual.
• observed — Modified behavior in src/menu/views/load_rom.c: Changes the display labels for MARKET_OTHER_X, MARKET_OTHER_Y, and MARKET_OTHER_Z from generic regional/unknown descriptions to “PAL (Regional),” “European (Regional),” and “PAL (Miscellaneous),” and updates their explanatory comments.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely identifies both main changes: setting the Z region to PAL and fixing the region link.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 2 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

Simplify code

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[networkfusion]

LGTM.