Skip to content

Fix/emulator rom offset validation #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
networkfusion wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Fix/emulator rom offset validation #402

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c14e29
Validate rom_offset from emulators.ini to prevent unsigned wrap
networkfusion Aug 26, 2026
0c9fbe1
Clarify why rom_offset is capped at MiB(64) despite 78MB cart capacity
networkfusion Aug 26, 2026
13ea062
Merge branch 'develop' into fix/emulator-rom-offset-validation
networkfusion Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/menu/cart_load.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,10 @@ cart_load_err_t cart_load_emulator (menu_t *menu, cart_load_emu_type_t emu_type,
if (rom_offset_str) {
char *end = NULL;
unsigned long parsed = strtoul(rom_offset_str, &end, 0);
if (end != rom_offset_str && *end == '\0') {
// flashcart_load_file() writes to ROM_ADDRESS + rom_offset within the primary
// 64MB SDRAM window on every flashcart (no extended-region support in load_file),
// so reject offsets that would make (MiB(64) - rom_offset) wrap.
if (end != rom_offset_str && *end == '\0' && parsed < MiB(64)) {
emulated_rom_offset = (uint32_t) parsed;
}
}
Expand Down
Loading