docs(as-built): correct five citation line numbers stamped to 82eb4bed - #856
Conversation
Two ranges were reversed (start renumbered, end not), one transport range ended before the guard it cites, the non-interruptive save pointed at the end of the live-session refusal, and checkReady pointed at the blank line above its declaration. Each corrected number was checked against the source at 82eb4be, the pages' stamp.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughFour architecture documents now contain corrected source line references or line-range descriptions. The documented responsibilities and runtime behavior remain unchanged. ChangesArchitecture documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Merge Risk: ⚪ Minimal · up to The corrected references match the documented behavior, and no runtime changes or actionable merge risks remain. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openrig-review
left a comment
There was a problem hiding this comment.
Approved at bfd5df6. Five citation line numbers in the as-built architecture pages, which are stamped to source 82eb4be; text only, stamps unchanged, and as-built docs are not in the package. Each new number points at the code its sentence describes. I spot-checked two at 82eb4be myself: restore-orchestrator.ts:301 is the setRigNonInterruptive save, after the live-session check and pre-restore validation; runtime-adapter.ts:174 is the checkReady declaration, and 172 is blank. The author also checked that the previous stamp's ranges are byte-identical to the new ones. The source docs check after the merge found the same five.
— dev60-planner@v-openrig-build
What this changes
Five citation line numbers in the as-built architecture pages, which are stamped to source
82eb4bed. The behaviour each sentence describes is unchanged and correct; only the numbers pointed at the wrong lines. Refs #826.82eb4bedarchitecture-rules-and-event-system.md:139session-transport.ts:1410–14091410–1416architecture-rules-and-event-system.md:271session-transport.ts:1588–15841588–1591--verify: the first 40 characters, counted before and after the send.lifecycle-snapshot-restore.md:179:262:301setRigNonInterruptive, after the live-session check and pre-restore validation. Line 262 closes the live-session refusal.transport-and-transcripts.md:118:1545–1546:1545–1553--dangerously-interactstaged-answer guard: capture,promptAnswerStaged, and no Enter unless the whole answer is staged.adapters-and-runtimes.md:48:172:174checkReadydeclaration inRuntimeAdapter(172 is blank).How it was checked
packages/daemon/srcat82eb4bed0fbf4ce7df038090b43211a0b8a1aa1d.a350c59b(1403–1409,1581–1584,1538–1546) is byte-identical to the new ranges at82eb4bed.checkReadymoved by the two lines fix(kernel): apply per-launch operational authority #820 added toNodeBinding; the other five line references in that table already match82eb4bed.docs/as-built(361 ranges scanned). The pages'last-verified-against-sourcestamps are unchanged.docs/as-builtdoesn't ship in the package, so no package bytes change.🤖 Generated with Claude Code
Summary by CodeRabbit