feat(finance): add needs_repush signal to MB push preview - #56
Merged
Conversation
Surface MB heads whose pushed cst_mb_cost row points at a superseded (or orphaned) source cost while a newer non-superseded calc result exists. These heads were already pushable but indistinguishable from freshly-computed ones, so a stale approved value could persist unnoticed. New field numbers only, no renumbering: - PushableMbHead.needs_repush = 7 - PreviewPushToHeadResponse.needs_repush_count = 4 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
github-project-automation
Bot
moved this from Todo
to Done
in Goapps Roadmap [Shared-Proto]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Surface MB heads whose pushed
cst_mb_costrow points at a superseded (or orphaned) source cost while a newer non-superseded calc result exists. These heads were already pushable but indistinguishable from freshly-computed ones, so a stale approved value could persist unnoticed.Change Type
Proto Files Changed
common/v1/common.protofinance/v1/uom.protofinance/v1/Changes Made
needs_repush = 7field toPushableMbHeadneeds_repush_count = 4field toPreviewPushToHeadResponseRelated Issues
Fixes #
Related to #
Breaking Change Check
Is this a breaking change?
buf breakingpassesBreaking Change Evidence
Lint Check
# Output of buf lint buf lintGenerated Code Preview (Optional)
Pre-merge Checklist
buf format -wappliedbuf lintpassesbuf breakingpassesImpact Assessment
Reviewer Notes
New field numbers added only, without renumbering:
PushableMbHead.needs_repush = 7PreviewPushToHeadResponse.needs_repush_count = 4