fix(ppc/proto): add customer_code and customer_name to Demand - #52
Merged
ilramdhan merged 1 commit intoJul 30, 2026
Merged
Conversation
Denormalize the PPC customer master's code and name onto Demand via customer_id, the same way product_code/product_name already are. The demand list and detail views must name the customer without a second round trip, and a bare id is never shown to a planner. Authored-By: Ilham R <ilhamram332@gmail.com> Co-Authored-By: Ilham R <me@ilramdhan.dev> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Co-Authored-By: IT Mutugading <it@mutugading.com> Co-Authored-By: Indra Putro <indraputro@mutugading.com> Co-Authored-By: Ilham R <ilham.ramadhan@mutugading.com> Co-Authored-By: IT Mutu Gading <mutugadingapps@gmail.com>
ilramdhan
added
bug
github-project-automation
Bot
moved this from Todo
to Done
in Goapps Roadmap [Shared-Proto]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR ini melakukan denormalisasi data dengan menambahkan field
customer_codedancustomer_nameke dalam message/entitasDemand(berdasarkancustomer_id). Pendekatan ini selaras dengan apa yang sudah dilakukan padaproduct_codedanproduct_name. Tujuannya adalah untuk optimasi performa frontend—halaman demand list dan detail kini dapat langsung menampilkan identitas customer tanpa perlu melakukan request tambahan ke backend (second round trip), memastikan planner tidak lagi melihat ID mentah.Change Type
Proto Files Changed
common/v1/common.protofinance/v1/uom.protodemand.proto(Silakan sesuaikan dengan nama file proto PPC yang relevan)Changes Made
customer_code(opsional/string) pada messageDemand.customer_name(opsional/string) pada messageDemand.Related Issues
Fixes #
Related to #
Breaking Change Check
Is this a breaking change?
buf breakingpassesBreaking Change Evidence
Lint Check
# Output of buf lint buf lintGenerated Code Preview (Optional)
// Generated Go code changesPre-merge Checklist
buf format -wappliedbuf lintpassesbuf breakingpassesImpact Assessment
Reviewer Notes
customer_codedancustomer_namesaat me-return dataDemand.