feat(finance/proto): add machine_id field to MBHead for cost resolution - #49
Merged
Merged
Conversation
Adds optional machine_id to MBHead and mbh_machine_id to Create/UpdateMBHeadRequest, referencing mst_machine.mc_id. Backs the MACHINE_MB_FIXED_TOTAL cost parameter resolution fix on the finance backend, replacing a hardcoded zero. Authored-By: Ilham R <ilhamram332@gmail.com> Co-Authored-By: Ilham R <me@ilramdhan.dev> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: IT Mutugading <it@mutugading.com> Co-Authored-By: Indra Putro <indraputro@mutugading.com> Co-Authored-By: Ilham R <ilham.ramadhan@mutugading.com> Co-Authored-By: IT Mutu Gading <mutugadingapps@gmail.com>
ilramdhan
added
bug
github-project-automation
Bot
moved this from Todo
to Done
in Goapps Roadmap [Shared-Proto]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR ini menambahkan field
machine_id(opsional) pada messageMBHead, sertambh_machine_idpadaCreateMBHeadRequestdanUpdateMBHeadRequest. Penambahan field ini berfungsi sebagai referensi kemst_machine.mc_idguna mendukung perbaikan resolusi parameter costMACHINE_MB_FIXED_TOTALdi backend finance, menggantikan nilai hardcoded zero (0) yang sebelumnya digunakan.Change Type
Proto Files Changed
common/v1/common.protofinance/v1/uom.protoyarn_master.proto(silakan sesuaikan nama file protonya)Changes Made
machine_idpada messageMBHead.mbh_machine_idpadaCreateMBHeadRequestdanUpdateMBHeadRequest.Related Issues
Fixes #
Related to #
Breaking Change Check
Is this a breaking change?
buf breakingpassesBreaking Change Evidence
Lint Check
# Output of buf lint buf lintGenerated Code Preview (Optional)
// Generated Go code changesPre-merge Checklist
buf format -wappliedbuf lintpassesbuf breakingpassesImpact Assessment
Reviewer Notes
MACHINE_MB_FIXED_TOTAL. Pastikan backend mapper sudah menangkap fieldmbh_machine_idini dan mengaitkannya ke relasimst_machine.mc_idagar resolusi biayanya tidak lagi mengembalikan nilai nol (hardcoded zero).