feat(finance/proto): add MB batch costing suite, workflow RPCs, and recipe lock - #48
Merged
Merged
Conversation
Add the Master Batch (MB) costing suite to yarn_master.proto: MB Head workflow RPCs (Submit/Approve/Validate/UnApprove/Revoke) plus six new services — MbComposition, MbLusture, MbParam, MbPush, MbWorkflowLog and MbBatch — with their CRUD, import/export, push-to-head and batch-trigger messages. Extend cost_product_master.proto with the MB-recipe lock: `source` and `is_locked` fields on CostProductMaster and an UnlockCostProductMaster RPC (finance-admin escape hatch for MB-recipe-locked products). Bump buf.lock from the dependency update run during code generation. Authored-By: Ilham R <ilhamram332@gmail.com> Co-Authored-By: Ilham R <me@ilramdhan.dev> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: IT Mutugading <it@mutugading.com> Co-Authored-By: IT Mutu Gading <mutugadingapps@gmail.com>
ilramdhan
added
bug
github-project-automation
Bot
moved this from Todo
to Done
in Goapps Roadmap [Shared-Proto]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR ini menambahkan sekumpulan proto contracts baru untuk mendukung fitur Master Batch (MB) costing suite pada
yarn_master.proto. Penambahan ini mencakup workflow MB Head, enam service baru beserta operasi CRUD dan bulk-nya. Selain itu, PR ini juga menambahkan mekanisme penguncian resep MB (MB-recipe lock) pada product master dan pembaruan dependensi padabuf.lock.Change Type
Proto Files Changed
common/v1/common.protofinance/v1/uom.protoyarn_master.proto,cost_product_master.proto,buf.lockChanges Made
yarn_master.proto(Submit, Approve, Validate, UnApprove, Revoke).MbComposition,MbLusture,MbParam,MbPush,MbWorkflowLog, danMbBatchbeserta seluruh operasi CRUD, import/export, push-to-head, dan batch-trigger messages.cost_product_master.protodengan penambahan mekanisme penguncian MB-recipe (menambahkan fieldsourcedanis_lockedpadaCostProductMaster).UnlockCostProductMastersebagai fitur pengaman darurat (escape hatch) bagi finance-admin untuk membuka kunci pada produk yang berstatus MB-recipe-locked.buf.locksebagai hasil dari penyesuaian dependensi (dependency update) saat proses code generation.Related Issues
Fixes #
Related to #
Breaking Change Check
Is this a breaking change?
buf breakingpassesBreaking Change Evidence
Lint Check
# Output of buf lint buf lintGenerated Code Preview (Optional)
// Generated Go code changesPre-merge Checklist
buf format -wappliedbuf lintpassesbuf breakingpassesImpact Assessment
Reviewer Notes
UnlockCostProductMasteryang secara spesifik dirancang untuk role finance-admin agar dapat membuka kunci (unlock) produk jika terjadi isu atau revisi mendesak terkait MB-recipe.buf.lock, mohon sinkronisasi local environment Anda jika diperlukan.