feat(finance/proto): CPR workflow revamp, route graph coordinates, param UI display, and validation fixes - #47
Merged
Conversation
…er to Parameter Extend Parameter message and UpdateParameterRequest with two new fields so operators can configure which parameters appear in the CPR approval drawer and in what order. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Enables grouped, ordered rendering of param values in the parameter summary drawer (param-detail-drawer). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ute proto Additive fields for the routing pages UX batch: aggregate level_count/rm_count on CostRouteHead for the list view, and persisted position_x/position_y + rm_group_name on CostRouteRm for the graph editor (free RM drag + group label). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… changes Combines two batches whose proto edits landed interleaved in the working tree: - product-requests-ux-batch: extend ListCostProductRequestsRequest.sort_by (type/title/customer/class/urgency), allow "pending" product_classification on Create/Update. - product-request-workflow-revamp: add cpr_reference_product_sys_id field, new SubmitAndDecideCostProductRequest RPC (merges Submit+StartReview+ VerifyClassification+DecideFeasibility+conditional LinkRoute), and additive Export/Import/Template RPCs for bulk request handling. All changes additive; buf breaking clean except pre-existing/pre-approved D2 shade-rename findings. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
raw_material_type, paper_tube_type_id, weight_per_bobbin_kg, and box_type
are deprecated for new writes, which always send zero values ("" / 0).
The prior required-value validation rejected those writes; add
IGNORE_IF_ZERO_VALUE so validation only applies to historical rows that
still carry a value.
github-project-automation
Bot
moved this from Todo
to Done
in Goapps Roadmap [Shared-Proto]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR ini membawa beberapa pembaruan signifikan untuk mendukung UI/UX dan alur kerja (workflow) pada modul finance. Pembaruan meliputi penambahan field pengaturan tampilan drawer parameter di UI, penambahan field koordinat dan agregasi pada
CostRouteuntuk graph editor, perombakan RPC workflow padaCostProductRequest(termasuk bulk handling), perbaikan validasi untuk field yang sudah deprecated, serta penambahan dokumentasi terkait hasil audit bulan Juli 2026.Change Type
Proto Files Changed
common/v1/common.protofinance/v1/uom.protoparameter.proto,cost_product_parameter.proto,cost_route.proto,cost_product_request.proto(Silakan sesuaikan dengan nama file aslinya)Changes Made
is_approval_visibledanapproval_display_orderpadaParameterdanUpdateParameterRequestagar operator dapat mengatur parameter mana yang muncul di CPR approval drawer. Menambahkandisplay_groupdandisplay_orderkeParamValueEntryuntuk kebutuhan rendering pada param-detail-drawer.level_countdanrm_countpadaCostRouteHead(untuk kebutuhan list view). Menambahkan field koordinatposition_x,position_y, danrm_group_namepadaCostRouteRmuntuk mendukung free drag dan pengelompokan label pada graph editor.sort_bypadaListCostProductRequestsRequestdan mengizinkan klasifikasi "pending" saat Create/Update. Menambahkan fieldcpr_reference_product_sys_iddan satu RPC terpadu baru, yaituSubmitAndDecideCostProductRequest(menggabungkan Submit, StartReview, VerifyClassification, DecideFeasibility, LinkRoute). Menambahkan RPC Export/Import/Template untuk bulk request handling.IGNORE_IF_ZERO_VALUEpada deprecated product spec fields (raw_material_type,paper_tube_type_id,weight_per_bobbin_kg,box_type). Hal ini agar validasi tidak me-reject write/create data baru yang otomatis mengirimkan nilai zero value ("" atau 0) pada field-field deprecated tersebut.Related Issues
Fixes #
Related to #
Breaking Change Check
Is this a breaking change?
buf breakingpassesBreaking Change Evidence
Lint Check
# Output of buf lint buf lintGenerated Code Preview (Optional)
// Generated Go code changesPre-merge Checklist
buf format -wappliedbuf lintpassesbuf breakingpassesImpact Assessment
Reviewer Notes
SubmitAndDecideCostProductRequest. RPC ini adalah wrapper baru yang menggabungkan beberapa state transitions CPR (Submit -> Review -> Verify -> Decide -> LinkRoute) ke dalam satu pemanggilan (mengurangi round-trip ke backend).IGNORE_IF_ZERO_VALUEagar backward compatible saat melakukan update/create di mana front-end hanya mengirim zero value.