feat(iam): add menu_id/menu_title to permission proto - #45
Merged
ilramdhan merged 1 commit intoJul 1, 2026
Merged
Conversation
github-project-automation
Bot
moved this from Todo
to Done
in Goapps Roadmap [Shared-Proto]
There was a problem hiding this comment.
Pull request overview
This PR updates the IAM permission proto definitions to support associating permissions with an owning UI menu/page (via menu_id and display menu_title), enabling permissions to be grouped and filtered by menu.
Changes:
- Added
menu_id/menu_titletoPermissionDetailfor response payload enrichment. - Added
menu_idtoCreatePermissionRequestandUpdatePermissionRequest, and added amenu_idfilter toListPermissionsRequest. - Updated
CreatePermissionRequest.descriptionvalidation (now includesmin_len: 1).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+326
to
+329
| string description = 3 [(buf.validate.field).string = { | ||
| min_len: 1 | ||
| max_len: 500 | ||
| }]; |
| optional string permission_name = 2 [(buf.validate.field).string.max_len = 100]; | ||
| optional string description = 3 [(buf.validate.field).string.max_len = 500]; | ||
| optional bool is_active = 4; | ||
| optional string menu_id = 5 [(buf.validate.field).string.uuid = true]; |
| ] | ||
| }]; | ||
| // Filter by menu_id (owning page/menu) | ||
| string menu_id = 10; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change Type
Proto Files Changed
common/v1/common.protofinance/v1/uom.protoChanges Made
Related Issues
Fixes #
Related to #
Breaking Change Check
Is this a breaking change?
buf breakingpassesBreaking Change Evidence
Lint Check
# Output of buf lint buf lintGenerated Code Preview (Optional)
// Generated Go code changesPre-merge Checklist
buf format -wappliedbuf lintpassesbuf breakingpassesImpact Assessment
Reviewer Notes