Skip to content

Require Qt 6.10, support up to 6.11 - #399

Merged
RomanPudashkin merged 2 commits into
musescore:mainfrom
RomanPudashkin:min_max_qt_version
Oct 30, 2026
Merged

RomanPudashkin merged 2 commits into
musescore:mainfrom
RomanPudashkin:min_max_qt_version

Conversation

@RomanPudashkin

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between da3885c and 8461208.

Files selected for processing: 6
  • buildscripts/cmake/SetupQt6.cmake
  • framework/cloud/internal/abstractcloudservice.cpp
  • framework/extensions/internal/extensioninstaller.cpp
  • framework/uicomponents/qml/Muse/UiComponents/CMakeLists.txt
  • framework/uicomponents/qml/Muse/UiComponents/StubStyledRectangularShadow.qml
  • framework/uicomponents/qml/Muse/UiComponents/sortfilterproxymodel.cpp
Files with no reviewable changes: 4
  • framework/extensions/internal/extensioninstaller.cpp
  • framework/cloud/internal/abstractcloudservice.cpp
  • framework/uicomponents/qml/Muse/UiComponents/sortfilterproxymodel.cpp
  • framework/uicomponents/qml/Muse/UiComponents/StubStyledRectangularShadow.qml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The project now requires Qt 6.10 and declares support through Qt 6.11. Qt-version branches were removed from OAuth configuration, authorization error logging, extension error formatting, and proxy-model filter changes. QML setup now always registers StyledRectangularShadow.qml, and the older stub component was removed.

Priority: Low

Merge Risk: Minimal · up to 84612

No concrete correctness, compatibility, or availability risk is established for this change.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The pull request has no description. It does not provide the required issue reference, change summary, motivation, checklist responses, or applicable testing and AI-assistance details. Add a description that follows the repository template. Include the resolved issue, a short summary and motivation, completed checklist items, testing details, prior-attempt information, and applicable unit-test or AI-assistance information…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main changes: requiring Qt 6.10 and supporting Qt versions up to 6.11.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Full details: Description check

Resolution

Add a description that follows the repository template. Include the resolved issue, a short summary and motivation, completed checklist items, testing details, prior-attempt information, and applicable unit-test or AI-assistance information.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@RomanPudashkin
RomanPudashkin merged commit 7a27874 into musescore:main Oct 30, 2026
3 checks passed
@RomanPudashkin
RomanPudashkin deleted the min_max_qt_version branch October 30, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants