Skip to content

[4.7] Fix #35454: Do not activate a VST before its processing is set up - #35455

Open
manolo wants to merge 1 commit into
musescore:4.7from
manolo:4.7-fix-vst-activate-before-setup
Open

manolo wants to merge 1 commit into
musescore:4.7from
manolo:4.7-fix-vst-activate-before-setup

Conversation

@manolo

@manolo manolo commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Resolves: #35454

Backport of musescore/muse_framework#401 to 4.7. VstAudioClient::ensureActivity() no longer activates the component until setupProcessing() has succeeded. Exporting all parts of the score from the issue 8 times on this branch: 1 complete export out of 8 without the change, 8 out of 8 with it.

  • I signed the CLA.
  • The title of the PR describes the problem it addresses.
  • The code in the PR follows the coding rules.
  • There are no unnecessary changes.
  • Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
  • The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
  • No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.

Complete only if applicable:

  • I created a unit test or vtest to verify the changes I made.
  • This PR was created using AI assistance; I have read, understood and complied following the guidelines for AI-assisted contributions. The AI tool(s) I used are listed below.
    • Claude Code 2.1.306 (Claude Opus 5.5)

…et up

An instrument that finishes loading after its track was switched on, as
happens when exporting parts, was activated without setupProcessing() and
then processed with no output buffers.

Assisted-by: Claude Code 2.1.306 (Claude Opus 5.5)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant