Skip to content

Don't lay out whole score when changing clef type - #35447

Open
miiizen wants to merge 1 commit into
musescore:mainfrom
miiizen:changeClefLayoutRange
Open

miiizen wants to merge 1 commit into
musescore:mainfrom
miiizen:changeClefLayoutRange

Conversation

@miiizen

@miiizen miiizen commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

We only need to lay out up to the next clef - like we do in ChangeKeySig.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 2b78bce and fa486cb.

Files selected for processing: 1
  • src/engraving/editing/editclef.cpp

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

ChangeClefType::flip() replaces the full-score layout trigger with a layout trigger on the clef and a layout request from the next clef tick for its staff.

Priority: Low

Merge Risk: Minimal · up to fa486

The change is mergeable; its narrower layout request preserves the intended clef-layout behavior.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description states the intended layout range, but it omits the required issue reference and all repository checklist items. Add a Resolves issue reference, retain the motivation, and complete the required checklist. Add any applicable unit-test or AI-assistance details.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: limiting layout after a clef-type change instead of laying out the whole score.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants