Skip to content

Fix macOS codesign: remove dSYM from QuickLook appex before signing - #35441

Merged
RomanPudashkin merged 1 commit into
musescore:mainfrom
RomanPudashkin:fix_macos_codesign_mss
Oct 30, 2026
Merged

RomanPudashkin merged 1 commit into
musescore:mainfrom
RomanPudashkin:fix_macos_codesign_mss

Conversation

@RomanPudashkin

Copy link
Copy Markdown
Contributor

Ports: #35337

@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 2abc2de and e61a066.

Files selected for processing: 1
  • src/macos_integration/CMakeLists.txt

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The macOS install cleanup now recursively removes the Quick Look extension’s MuseScoreQuickLookPreviewExtension.dSYM directory before signing the extension.

Priority: Low

Merge Risk: Minimal · up to e61a0

The macOS cleanup change is narrowly scoped and introduces no identified merge-blocking risk.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description only links to another pull request. It does not provide the required issue reference, change motivation, checklist responses, testing information, or AI-assistance details when applica… Add the required issue reference and a short description of the change and motivation. Complete all applicable checklist items, including testing, coding rules, unnecessary changes, commit purpose, prior attempts, unit or vtest coverage, an…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: removing the Quick Look appex dSYM before macOS code signing.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description only links to another pull request. It does not provide the required issue reference, change motivation, checklist responses, testing information, or AI-assistance details when applicable.

Resolution

Add the required issue reference and a short description of the change and motivation. Complete all applicable checklist items, including testing, coding rules, unnecessary changes, commit purpose, prior attempts, unit or vtest coverage, and AI-assistance compliance when applicable.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@RomanPudashkin
RomanPudashkin merged commit 2b78bce into musescore:main Oct 30, 2026
15 checks passed
@RomanPudashkin
RomanPudashkin deleted the fix_macos_codesign_mss branch October 30, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants