[0xMashiro]

Resolves: #35348

Correct Unicode literals in chord-symbol editing and Jazz kerning. The double-sharp and double-flat literals used four-digit escapes for supplementary-plane code points, so neither the Jazz kerning entries nor the end-of-edit replacements matched those symbols. The adjacent diminished-chord replacement also used U+00D0 (Latin Eth) instead of U+00B0 (degree sign).

Use the correct code points while retaining the existing kerning values and Jazz-only condition. This completes the kerning cases missed by #30362 (#30285); the editing omissions were pointed out in #35349 (comment).

The existing harmony-46 vtest covers both double accidentals before minor/major seventh suffixes, retaining the original first measure as a control. A new test in the existing TextBase suite exercises startEdit, InsertText and endEdit, comparing chord names and parsed root/bass/description information with normal text input. It covers both accidentals in roots and slash basses, the degree sign, and ordinary sharp/flat controls. No new score fixture is needed for editing.

Validation:

• Rebased onto official main ac179663cfe2c685b720c68611dbac67c63038d8. Before correcting Harmony::endEdit, the unchanged editing regression fails for the four double-accidental inputs and C°7; the two ordinary-accidental controls pass.
• With the correction, all 14 TextBase and FretDiagram tests pass, including all seven inputs in the regression. Independent compilation of harmony.cpp and textbase_tests.cpp, upstream Uncrustify and diff checks pass.
• The earlier matched native visual evidence below was generated on 26fb3eb5. All four added kerning cases receive the adjustment; the original first-measure text positions and full DrawData for harmony-40, harmony-41 and a Standard-style control remain unchanged. The existing harmony-6 double-sharp case changes as expected. These images and the visual fixture are unchanged by the editing follow-up.
• Native tests/renders use ASAN_OPTIONS=detect_leaks=0. No full-suite, GUI editing, or leak-free result is claimed.

Before	After

Compare the gap after the double accidentals in the second system. The first system is unchanged.

• I signed the CLA.
• The title of the PR describes the problem it addresses.
• The code in the PR follows the coding rules.
• There are no unnecessary changes.
• Each commit's message describes its purpose and effects, and references the issue it resolves. If changes are extensive, there is a sequence of easily reviewable commits.
• The code compiles and runs on my machine, preferably after each commit individually. I have manually tested and verified that my changes fulfil their intended purpose.
• No prior attempts to resolve this problem exist, or if they do, I listed them in my PR description and described how I avoided repeating past mistakes.

Complete only if applicable:

• I created a unit test or vtest to verify the changes I made.
• This PR was created using AI assistance; I have read, understood and complied following the guidelines for AI-assisted contributions. The AI tool(s) I used are listed below.

OpenAI Codex was used to improve efficiency during development.

[coderabbitai]

No actionable comments were generated in the recent review.

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: musescore/MuseScore/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 79a94a90-c940-4cb1-9bf8-84d2fa2018d9

📥 Commits

Reviewing files that changed from the base of the PR and between 26fb3eb and 4678bb8.

📒 Files selected for processing: 2

• src/engraving/rendering/score/harmonylayout.cpp
• vtest/scores/harmony-46.mscz

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The Jazz kerning keys for double-sharp and double-flat now use eight-digit Unicode escapes for U+1D12A and U+1D12B. The existing kerning adjustment values are unchanged.

Priority: Low

Severity of issue fixed: Low

Merge Risk: Minimal · up to 4678b

The corrected keys match the symbols emitted by Jazz chord rendering, and the updated fixture covers both accidentals with both suffix types. No actionable merge risk remains.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		The PR satisfies the coding requirements in [#35348]. It replaces the malformed four-digit escapes with \\U0001D12A and \\U0001D12B. The existing -0.15 values remain unchanged. The PR changes only…
Out of Scope Changes check		The changes stay within [#35348]. The source change fixes double-sharp and double-flat Jazz kerning. The harmony-46.mscz change provides the related regression coverage. No unrelated source or test …
Title check		The title clearly summarizes the two related fixes: correcting Unicode symbols in chord editing and Jazz kerning.
Description check		The description is complete and directly addresses the template. It includes the resolved issue, motivation, implementation details, testing evidence, limitations, visual evidence, and completed check…

Full details: Linked Issues check

Explanation

The PR satisfies the coding requirements in [#35348]. It replaces the malformed four-digit escapes with \U0001D12A and \U0001D12B. The existing -0.15 values remain unchanged. The PR changes only the Jazz kerning entries and retains the existing Jazz-only behavior. The harmony-46.mscz vtest fixture also changes for the reported double-accidental cases.

Full details: Out of Scope Changes check

Explanation

The changes stay within [#35348]. The source change fixes double-sharp and double-flat Jazz kerning. The harmony-46.mscz change provides the related regression coverage. No unrelated source or test changes appear in the whole-PR diff.

Full details: Description check

Explanation

The description is complete and directly addresses the template. It includes the resolved issue, motivation, implementation details, testing evidence, limitations, visual evidence, and completed checklist items.

✨ Finishing Touches: 💡 1

🧪 Generate unit tests (beta)

• Create a new PR

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[mercuree]

MuseScore/src/engraving/dom/harmony.cpp

Line 797 in ac17966

s.replace(u"\u1d12b", u"bb"); // double-flat

MuseScore/src/engraving/dom/harmony.cpp

Line 806 in ac17966

s.replace(u"\u1d12a", u"x"); // double-sharp

Do these lines also need to be fixed?

[0xMashiro]

Yes, thanks for catching those. Fixed both in cd88b7e and added a regression that exercises ending an actual chord-symbol edit, including double accidentals in roots and slash basses.

I also checked the adjacent replacements: the degree-sign case used U+00D0 (Ð) rather than U+00B0 (°). C°7 failed the same editing test, so I corrected that line too. Ordinary sharp/flat inputs are passing controls. All 14 TextBase and FretDiagram tests pass after the changes.

The broader escape search found no further instances of this mistake in the scanned source; the OVE matches are valid natural signs followed by 7.