Repository navigation
Update Bravura to 1.482 - #34489
Update Bravura to 1.482#34489
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. ℹ️ Recent review info
Walkthrough
Merge Risk:
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description is largely incomplete. It only states that Bravura was recently released and omits the required issue reference, change summary, motivation, and checklist responses. | Add the applicable issue reference, describe the Bravura 1.482 update and its motivation, and complete every checklist item in the repository template. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request. Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request. Title check ✅ Passed The title clearly identifies the primary change: updating Bravura to version 1.482.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create PR with unit tests
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@fonts/bravura/FONTLOG.txt`:
- Line 486: Update the changelog entry for noteheadDiamondDoubleWhole and
noteheadDiamondWhole to use the past-tense “Improved” instead of “Improve,”
matching the surrounding completed-change entries.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 413437be-0efc-44da-af7f-70b456963dd4
📥 Commits
Reviewing files that changed from the base of the PR and between f4cdc6b and 9ce5375deefb5878eaa03a80a11f4fe777427302.
⛔ Files ignored due to path filters (2)
fonts/bravura/Bravura.otfis excluded by!**/*.otffonts/bravura/BravuraText.otfis excluded by!**/*.otf
📒 Files selected for processing (4)
fonts/bravura/FONTLOG.txtfonts/bravura/LICENSE.txtfonts/bravura/README.mdfonts/bravura/bravura_metadata.json
|
The vtest differences are very minimal, as far as I can tell, except for this (just updated for 1.481): |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@fonts/bravura/bravura-text.md`:
- Line 57: Update the navigation terminology in the paragraph: use the current
macOS path “System Settings → Keyboard → Keyboard Shortcuts → Input Sources”
instead of the legacy pane/tab wording, and replace “OS X” with “macOS”;
preserve the shortcut instructions and examples.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 56eb6384-2139-445b-ae39-751cd359879c
⛔ Files ignored due to path filters (2)
fonts/bravura/Bravura.otfis excluded by!**/*.otffonts/bravura/BravuraText.otfis excluded by!**/*.otf
📒 Files selected for processing (7)
fonts/bravura/Bravura.jsonfonts/bravura/FONTLOG.txtfonts/bravura/LICENSE.txtfonts/bravura/README.mdfonts/bravura/bravura-text.mdfonts/bravura/bravura_metadata.jsonsrc/engraving/data/fonts/fonts_Bravura.qrc
🚧 Files skipped from review as they are similar to previous changes (3)
- fonts/bravura/README.md
- fonts/bravura/LICENSE.txt
- src/engraving/data/fonts/fonts_Bravura.qrc
d7c0731 to
19062d3
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
@miiizen Could this please get reviewed? |
|
Should I rebase? |
|
Also might be good to get this into 4.7 too... |
No, please |
which got just released (24Aug26)