Repository navigation
fix: declare Multipeer's UDP Bonjour service and report Local Network access - #52
Merged
Merged
Conversation
… access Multipeer Connectivity browses both _<serviceType>._tcp and _<serviceType>._udp, and iOS's Local Network privacy blocks any service type missing from NSBonjourServices. The config plugin, README and example declared only the TCP entry; they now declare both. With Local Network access denied, Multipeer finds no peers and reports no error. requestLocalNetworkPermission(timeoutMs?) shows the prompt on first use and resolves 'granted', 'denied', 'notDetermined' or 'unavailable' by publishing and browsing the private _munimbluetooth._tcp service (ported from munim-wifi; the config plugin declares it). Android resolves 'granted'. The example checks it before starting Multipeer. Verified on an iPad Air M3 (iPadOS 27.0.1) and an iPhone 17 Pro: the two connect over Multipeer about 2 s after launch and exchange pings, and the check reports granted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
sheehanmunim
pushed a commit
that referenced
this pull request
Oct 17, 2026
## [0.10.2](v0.10.1...v0.10.2) (2026-10-17) ### 🐛 Bug Fixes * declare Multipeer's UDP Bonjour service and report Local Network access ([#52](#52)) ([fcd1c0c](fcd1c0c))
Member
Author
|
🎉 This PR is included in version 0.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing Multipeer between an iPad and an iPhone. The two never found each other, and nothing reported an error.
Bonjour UDP entry
Multipeer Connectivity browses both
_<serviceType>._tcpand_<serviceType>._udp. iOS's Local Network privacy blocks any service type missing fromNSBonjourServices._munim-mesh._tcp.multipeerServiceTypesentry, and also accepts._udp-suffixed input.requestLocalNetworkPermission(timeoutMs?)With Local Network access denied, Multipeer finds no peers and reports no error. iOS asks only once per app, so a denied app stays silent from then on.
'granted' | 'denied' | 'notDetermined' | 'unavailable'by publishing and browsing a private_munimbluetooth._tcpservice, which the config plugin declares. This is the same probe munim-wifi ships.'granted': Multipeer is Apple-only and BLE doesn't use the local network.Verified (Release builds)
munim-mesh-ping). The check reportsgranted.tsc,bob buildand nitrogen codegen pass.The Android change is a one-liner and is compiled by CI only.
Also tested in the same session, with no code changes needed: L2CAP iPad → Galaxy A14 (PSM 192, payload received), Android Classic RFCOMM server and discovery, and BLE GATT with three devices (the iPhone as central against the iPad and the Galaxy).
🤖 Generated with Claude Code