Repository navigation
fix: populate manufacturer data entries in scan results - #50
Merged
sheehanmunim merged 1 commit intoOct 8, 2026
Merged
sheehanmunim merged 1 commit into
sheehanmunim merged 1 commit into
Conversation
BLEDevice declares manufacturerDataEntries, but scan results never set it.
Android reported only the first manufacturer entry, dropping its company
identifier, while iOS reported CoreBluetooth's raw blob with the little
endian company identifier still prefixed.
Report every entry as { companyId, data } with the company identifier
parsed out on both platforms. manufacturerData is left untouched for
existing callers and deprecated.
sheehanmunim
pushed a commit
that referenced
this pull request
Oct 8, 2026
## [0.9.1](v0.9.0...v0.9.1) (2026-10-08) ### 🐛 Bug Fixes * iOS GATT promise mix-ups and crashes, Android short UUIDs, plugin scan permission ([#49](#49)) ([943959d](943959d)) * populate manufacturer data entries in scan results ([#50](#50)) ([480d6d8](480d6d8)) ### 📚 Documentation * move Installation up and list Expo first ([b31f5fd](b31f5fd))
Member
|
🎉 This PR is included in version 0.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BLEDevice declares manufacturerDataEntries, but scan results never set it. Android reported only the first manufacturer entry, dropping its company identifier, while iOS reported CoreBluetooth's raw blob with the little endian company identifier still prefixed.
Report every entry as { companyId, data } with the company identifier parsed out on both platforms. manufacturerData is left untouched for existing callers and deprecated.
Fixes "iOS: the deviceFound payload differs from Android (serviceData and the manufacturer-data prefix)."