Resolve downloads from the public mpx-cli repo - #4
Merged
Conversation
mpx's source repository is public, so its releases are published there and `multiplex-cli-releases` — which only ever existed to serve anonymous downloads for a closed repo — takes no new ones. v0.1.0–v0.1.2 are mirrored into mpx-cli byte-for-byte, so every sha256 here is unchanged; only the host half of each URL moved. bump.py needed a fix to survive the move: its target-triple patterns could cross `/`, so in a URL under `multiplex-term/mpx-cli` they matched that `mpx-` first and read a triple of `v0.2.0-aarch64-apple-darwin`, failing every bump with "the release has no archive for". Both patterns now match a single path segment, which is the filename. Regression test included. CI's audit gate also loses its conditional: `--online` was skipped while no public release existed to resolve against, and now one always does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mpx's source repository is public, so its releases are published there and
multiplex-cli-releases— which only ever existed to serve anonymous downloads for a closed repo — takes no new ones. v0.1.0–v0.1.2 are mirrored intompx-clibyte-for-byte, so everysha256here is unchanged; only the host half of each URL moved. All four new URLs were checked to return 200 anonymously.bump.pyneeded a fix to survive the move. Its target-triple patterns could cross/, so undermultiplex-term/mpx-clithey matched thatmpx-first and read a triple ofv0.2.0-aarch64-apple-darwin— failing every future bump withthe release has no archive for. Both patterns now match a single path segment, which is the filename. Regression test included, and the real formula round-trips throughbump.pywith v0.1.2's realSHA256SUMSto a byte-identical file.CI's audit gate also loses its conditional:
--onlinewas skipped while no public release existed to resolve against, and now one always does.Companion PR: mpx-cli#1 moves the release workflow.