Skip to content

If CFLAGS or CXXFLAGS are not set, apply -O2 #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattip merged 1 commit into from
Sep 27, 2026
+6 −2
Merged

If CFLAGS or CXXFLAGS are not set, apply -O2 #557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions configure_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,14 @@ if [ -n "$IS_MACOS" ]; then
echo "Invalid platform = '$PLAT'. Supported values are 'intel', 'x86_64', 'arm64' or 'universal2'"
exit 1
fi
ARCH_FLAGS="-O2 $ARCH_FLAGS"
# Only set CFLAGS, FFLAGS if they are not already defined. Build functions
# can override the arch flags by setting CFLAGS, FFLAGS
export FFLAGS="${FFLAGS:-$ARCH_FLAGS}"

STRIP_FLAGS="-O2 $ARCH_FLAGS"
export CFLAGS="${CFLAGS:-$ARCH_FLAGS}"
export CXXFLAGS="${CXXFLAGS:-$ARCH_FLAGS}"
export FFLAGS="${FFLAGS:-$ARCH_FLAGS}"

# Disable homebrew auto-update
export HOMEBREW_NO_AUTO_UPDATE=1
Expand All @@ -42,10 +45,11 @@ else
PLAT="${PLAT:-x86_64}"
# Strip all binaries after compilation.
STRIP_FLAGS=${STRIP_FLAGS:-"-Wl,-strip-all"}
export FFLAGS="${FFLAGS:-$STRIP_FLAGS}"

STRIP_FLAGS="-O2 $STRIP_FLAGS"
export CFLAGS="${CFLAGS:-$STRIP_FLAGS}"
export CXXFLAGS="${CXXFLAGS:-$STRIP_FLAGS}"
export FFLAGS="${FFLAGS:-$STRIP_FLAGS}"
if [[ $MB_ML_VER == "_2_24" ]]; then
# This is the first opportunity to distinguish between manylinuxes
apt update
Expand Down
Loading