Skip to content

[code-infra] Update renovate config and add vitest group - #14856

Merged
JCQuintas merged 3 commits into
mui:masterfrom
JCQuintas:vitest-renovate-merge
Oct 7, 2024
Merged

JCQuintas merged 3 commits into
mui:masterfrom
JCQuintas:vitest-renovate-merge

Conversation

@JCQuintas

Copy link
Copy Markdown
Member

@JCQuintas
JCQuintas requested a review from a team October 7, 2024 10:45
@JCQuintas JCQuintas self-assigned this Oct 7, 2024
@mui-bot

mui-bot commented Oct 7, 2024

Copy link
Copy Markdown

Deploy preview: https://deploy-preview-14856--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against f23bbd2

@Janpot Janpot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you feel about adding

pnpm --package renovate dlx renovate-config-validator --strict 

to CI? perhaps in the test_static job?

@JCQuintas

Copy link
Copy Markdown
Member Author

pnpm --package renovate dlx renovate-config-validator --strict

Do you think it would be worth it to run it on every pr? 🤔

@JCQuintas
JCQuintas merged commit 418615e into mui:master Oct 7, 2024
@JCQuintas
JCQuintas deleted the vitest-renovate-merge branch October 7, 2024 12:32
@Janpot

Janpot commented Oct 7, 2024

Copy link
Copy Markdown
Member

Do you think it would be worth it to run it on every pr? 🤔

Probably won't degrade overall CI time, but maybe it's too much, yeah...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants