Repository navigation
[code-infra] Use concurrency 1 in CircleCI - #14110
Merged
Merged
Conversation
|
Deploy preview: https://deploy-preview-14110--material-ui-x.netlify.app/ |
Member
Author
Janpot
approved these changes
Aug 5, 2024
Member
|
For #13855, I still have the issue for concurrency 1 :/ |
LukasTy
reviewed
Aug 6, 2024
Member
Author
|
@flaviendelangle changes here were successful for the ts step, others are failing still though: #14109 |
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Member
|
@JCQuintas I brought back all the demos and it seems to pass indeed |
brijeshb42
reviewed
Mar 10, 2026
| "test:regressions:server": "serve test/regressions -p 5001", | ||
| "test:argos": "node ./scripts/pushArgos.mjs", | ||
| "typescript": "lerna run --no-bail --parallel typescript", | ||
| "typescript:ci": "lerna run --concurrency 3 --no-bail --no-sort typescript", |
Contributor
There was a problem hiding this comment.
Typecheck is failing in CI after this was merged.
zannager
added
the
scope: code-infra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the issues where typescript checks are failing in CI
Circle CI only runs on 2 cpus: https://discuss.circleci.com/t/debugging-random-node-js-build-failures/39667
We should generally run
CPU_COUNT - 1concurrent processes, which leaves us at1for circlecimax-old-space-sizehas no effect on scripts that spawn multiple processes, so we can remove it in this instance.