Repository navigation
[test][form group] Add axe tests and WCAG conformance report - #49554
Open
michelengelen wants to merge 2 commits into
Open
michelengelen wants to merge 2 commits into
michelengelen wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploy previewBundle size
PerformanceNo regressions in 32 benchmarks · ran 4m 13s · details Check out the code infra dashboard for more information about this PR. |
1 task done
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds axe coverage, WCAG unit tests, and a WCAG 2.2 Level A/AA conformance report for
FormGroup. This is Wave 1, item 8 of #49260. Part of #49412.FormGroup
FormGroup renders a
divwith no role. Its group semantics come from afieldsetwith a legend, or fromrole="group"with a name. The docs show only thefieldsetpattern. No docs page or demo documentsrole="group"on FormGroup. Every rated criterion is ✅ · ◐ Shared, and the report states what the author must add.Report:
FormGroup/accessibility.mdRating decisions
The report rates a criterion only when FormGroup's own output governs it:
flex-wrap, so it rates 1.3.2, 1.4.10, and 2.4.3.role="group"and a name, FormGroup is the named group element, so it rates 1.3.1, 2.4.6, and 3.3.2.errorclass, but no error style, so 1.4.1 is not applicable.Changes
FormGroup.test.jshas two tests:role="group"witharia-labelledbygives a named group. This fails if FormGroup stops passing props to its root.FormGroupA11yStates, owns a newform-groupslug and asserts every rule. It covers a legend,row, an error group,role="group", an unnamed group, and a wide row.skipCriteria: ['1.4.4', '1.4.12']. The five-checkbox row wraps at 320 px.Findings recorded in the report
aria-labelon a FormGroup with no role. ARIA does not allow this. axe reports it only asincomplete, and no fixture exercises it.aria-invalid.Merge order with the sibling Wave 1 PRs
Do not hand-merge the generated blocks: after each rebase, run
pnpm a11y:scorecard.Not done in this PR
Follow-ups (tracked in #49477)
checkboxes.mdandswitches.mdshould say that a group needs afieldsetand legend, orrole="group"with a name. Document therole="group"pattern on FormGroup.aria-labelon the role-less FormGroup in FormControlLabelPosition. Connect the group headings in ScrollPlayground to their groups.🤖 Generated with Claude Code