Skip to content

[test][pagination] Test ellipses with zero boundary and sibling counts #49090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZeeshanTamboli merged 9 commits into from
Oct 28, 2026
Merged

[test][pagination] Test ellipses with zero boundary and sibling counts #49090

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ce2f9a2
[material-ui][Pagination] Hide ellipses with zero boundary and siblin…
lprnmns Sep 4, 2026
c582ee4
Merge branch 'master' into codex/fix-pagination-zero-boundaries
Janpot Sep 9, 2026
f34b0a1
[material-ui][Pagination] Handle compact pagination edge cases
lprnmns Sep 9, 2026
65d4dd8
[material-ui][Pagination] Add tests for page links near the edges
Janpot Sep 9, 2026
0e0dceb
[material-ui][Pagination] Keep adjacent page links with compact settings
lprnmns Sep 24, 2026
29821fd
Merge branch 'master' into codex/fix-pagination-zero-boundaries
ZeeshanTamboli Oct 23, 2026
7dfd9d9
[material-ui][Pagination] Keep ellipses with zero counts
lprnmns Oct 27, 2026
41783a1
Merge branch 'master' into codex/fix-pagination-zero-boundaries
ZeeshanTamboli Oct 28, 2026
859a5f6
Drop redundant tests
ZeeshanTamboli Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/mui-material/src/usePagination/usePagination.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,24 @@ describe('usePagination', () => {
]);
});

it('keeps ellipses when boundary and sibling counts are zero', () => {
const expectedByPage = [
[1, ['previous', 1, 2, 'end-ellipsis', 'next']],
[2, ['previous', 1, 2, 'end-ellipsis', 'next']],
[5, ['previous', 'start-ellipsis', 5, 'end-ellipsis', 'next']],
[7, ['previous', 'start-ellipsis', 7, 'end-ellipsis', 'next']],
[9, ['previous', 'start-ellipsis', 9, 10, 'next']],
[10, ['previous', 'start-ellipsis', 9, 10, 'next']],
];

expectedByPage.forEach(([page, expected]) => {
const items = renderHook(() =>
usePagination({ count: 10, page, boundaryCount: 0, siblingCount: 0 }),
).result.current.items;
expect(serialize(items), `page=${page}`).to.deep.equal(expected);
});
});

it('should never render a page item outside of the count range', () => {
[0, 1, 2, 3, 4, 5, 11].forEach((count) => {
[1, 3, 7].forEach((page) => {
Expand Down
Loading