[utils] Fix pseudo-element bounds in dev#5000
Open
atomiks wants to merge 1 commit into
Open
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,402.17 ms +211.42 ms(+17.8%) | Renders: 50 (+0) | Paint: 2,110.49 ms +329.24 ms(+18.5%)
7 tests within noise — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
b5b9a55 to
ff64de3
Compare
ff64de3 to
77ce714
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pseudo-element hit-area expansion was skipped in every non-production build. This keeps jsdom on the safe path while allowing real development browsers to calculate pseudo-element bounds.
Root cause
The jsdom workaround was tied to
NODE_ENV, so development browsers returned the element rect before reading pseudo-element styles.Changes