Repository navigation
feat: add Codex session links, responsive drawers, and safer deployment cleanup - #55
Conversation
- Preserve native source and item identities across live delivery and history. - Show outgoing delivery receipts and scoped read-only session links. - Keep the original reading position and reject stale preview responses. - Advance protocol and derived cache versions with regression coverage.
- Move the full-width chat with touch-driven sidebar progress and distance or velocity settling. - Preserve native scrolling, editor gestures, selection, keyboard sizing and desktop layout. - Load the gesture controller with the sidebar and replace legacy swipe checks with Chromium and WebKit coverage.
- Reveal a continuous sidebar surface beneath rounded conversation corners. - Use native Safari switch feedback for taps and supported vibration for opening gestures. - Cover layer clipping, gesture feedback, unsupported browsers and responsive controls.
- Animate pane transforms without invalidating the full conversation on each frame. - Let new touches interrupt settling and preserve recent flick velocity. - Cover repeated reversals, delayed touch endings, and exposed closing surfaces.
- Read resident state after asynchronous catalog and broker lookups complete. - Keep late session lists from restoring stale running or idle state across accounts. - Cover terminal, new-turn, and eviction races in catalog responses.
- Skip oversized rollout records within the bounded source snapshot to recover newer settings. - Validate the native resume model before replacing an unavailable selection. - Preserve explicit user overrides and cover missing or stale rollout settings.
- Add journaled retention with reviewed inventories, process and symlink checks, quarantine, and acceptance before removal. - Start Codex lifecycle commands from a stable home and verify live daemon configuration as the service user. - Package the cleanup tool and document rollback retention and deferred cleanup.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c9116fe7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| roots = [p for p in plan["protected"] if p.exists()] | ||
| roots.extend(p for p, reasons in observed.items() if reasons and p.exists()) |
There was a problem hiding this comment.
Trace dependencies from every retained candidate
When a candidate is retained because an explicit protected path is nested inside it, that candidate is added to found but not to roots; only candidates with live process references are traversed. For example, if retained candidate B contains a protected file and B/.venv points to candidate A, the scan starts at the protected file rather than B, misses the symlink, and can permanently delete A while retaining a now-broken B. Add all candidates already marked with retention reasons to the dependency roots before determining which other candidates are safe to remove.
AGENTS.md reference: AGENTS.md:L34-L37
Useful? React with 👍 / 👎.
- Trace whole retained candidates during single-path checks and through nested symlink targets. - Cover transitive retention, candidate ordering, cycles, and unobservable process records. - Keep real process tests isolated and verify safe CLI refusal on restricted Linux runners.
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Native Codex cross-session messages now show their source conversation and delivery outcome, with scoped read-only history links. This also improves mobile drawer interaction and fixes stale session state, model selection, and deployment cleanup failures.
Changes
Validation
The complete local gate passed against the unchanged source committed at
7d4a30e:No live model prompts were sent. Native App/MCP cross-session delivery and physical iOS haptics remain separate acceptance checks; no new Playwright run was performed for this PR.
Cleanup regression coverage
Retained candidates now contribute their entire dependency tree during single-candidate rescans and when a symlink references only a child directory. Five added retention regressions failed before the fix and pass now, including reverse candidate ordering and cyclic dependencies.
The Ubuntu CI failure was caused by real scans encountering restricted same-user
/procentries. Production scanning still refuses cleanup when visibility is incomplete. Tests now assert that refusal leaves files untouched and scope positive real-process checks to their own fixture process; three additional denied-record cases cover the safety boundary. All 42 cleanup tests pass locally. The Ubuntu CI run for7d4a30epassed both Web build and the full Python suite.Compatibility and rollout
cc-remote update. Existing daemon processes are not restarted to change their working directory; any release they still reference remains protected.