Skip to content

fix(BACKEND-TENSTORRENT-QWEN35): guard the empty-vector fwrite GCC 15 flags under -Werror=nonnull #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joral wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(BACKEND-TENSTORRENT-QWEN35): guard the empty-vector fwrite GCC 15 flags under -Werror=nonnull #2022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/vllm/model_executor/models/qwen3_5.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4016,7 +4016,13 @@ GdnQkvzOutput ProjectGdnQkvz(Dev d, const GdnLayerWeights& w, const Tensor& h,
vt::tenstorrent::DebugDeviceReadbackF32(d.q, wt);
std::FILE* f2 = std::fopen((dir + "/w_device.bin").c_str(), "wb");
if (f2) {
std::fwrite(vec.data(), 4, vec.size(), f2);
// issue #2021: `vec` may be empty, in which case `data()` may
// return `nullptr` -- well-defined for a size-0 `fwrite` by the
// C standard, but `fwrite`'s `nonnull` attribute makes GCC 15
// flag the call itself under -Werror=nonnull regardless of the
// runtime size. Guard rather than silence: there is nothing to
// write for an empty readback either way.
if (!vec.empty()) std::fwrite(vec.data(), 4, vec.size(), f2);
std::fclose(f2);
}
}
Expand Down
Loading