Improved Material Design compatibility - #38
Open
RafalZajfertMudita wants to merge 1 commit into
Open
RafalZajfertMudita wants to merge 1 commit into
RafalZajfertMudita wants to merge 1 commit into
Conversation
RafalZajfertMudita
force-pushed
the
md-compatibility
branch
from
September 10, 2026 10:20
5996fc3 to
a18a9bd
Compare
azabost
reviewed
Sep 10, 2026
azabost
reviewed
Sep 11, 2026
azabost
reviewed
Sep 11, 2026
azabost
reviewed
Sep 11, 2026
azabost
reviewed
Sep 11, 2026
azabost
reviewed
Sep 11, 2026
kkandyba
reviewed
Sep 11, 2026
| modifier: Modifier = Modifier, | ||
| enabled: Boolean = true, | ||
| shape: Shape = ButtonDefaultsMMD.shape, | ||
| colors: ButtonColors = ButtonDefaultsMMD.buttonColors(), |
There was a problem hiding this comment.
Should we use outlinedButtonColors() and outlinedButtonBorder(enabled) here, like in the other overload? Is there a reason for using different defaults?
Contributor
Author
There was a problem hiding this comment.
Good catch! It should be the same as in the main OutlinedButtonMMD method. Thanks!
RafalZajfertMudita
force-pushed
the
md-compatibility
branch
from
September 14, 2026 13:11
a18a9bd to
d32a5b7
Compare
azabost
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.