Repository navigation
DOC: The CG work fields stay in the collection - #253
Merged
Merged
Conversation
The docstrings and the Python reference still said the solver's work fields are removed again on return, which has not been true since the work fields were pooled. Say that they stay, how they are named, and that register_field_collection without field_names would write them to a file. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The Python IO tests write their NetCDF files into the source tree, and an in-source CMake run had left a CMakeCache.txt; none of it belongs in the repository. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#252 made the solvers keep their work fields in the collection between solves, but the
conjugate_gradients/conjugate_gradients_pipelineddocstrings and thefcrow of the Python reference still said they are "removed again on return" / "created and removed again", with the oldcg#<call>-<role>names.What changes
docs/python.mdsay the work fields stay (namedcg-work<depth>-<role>-...) and are reused by the next solve.FileIONetCDF.register_field_collectionof such a collection withoutfield_nameswrites the work fields too, since that is the one place where the persistence is visible to a user.Docs only; no code change, so no CHANGELOG entry beyond the existing PERF one.
🤖 Generated with Claude Code