Mark Source Products fields as optional - #732
Merged
Merged
Conversation
MTGJSON omits any finish a card was not printed in, so etched, foil, and nonfoil can each be absent from a sourceProducts object. Verified against 10E (cards with only nonfoil, and cards with only foil) and MH2 (cards with all three, and one with only foil). Adding the optional badge also flows into the generated TypeScript model, bringing it in line with the sibling SkuIds model. Fixes #662 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xba7S7uYsrKAVdniqNcfhS
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #732 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 69 69
Branches 27 27
=========================================
Hits 69 69 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #662
etched,foil, andnonfoilwere documented as required on the Source Products model, but MTGJSON omits any finish a card was not printed in.Verified against live data — counting which
sourceProductskeys are present per card:foil,nonfoilnonfoilonlyfoilonlyfoil,nonfoiletched,foil,nonfoilfoilonlyAll three fields turn up missing in practice, so each gets the
optionalbadge. That badge is whatutil/generate-types.jsreads, so the generated model becomes:This matches the sibling
SkuIdsmodel, which already declares its finish fields optional.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xba7S7uYsrKAVdniqNcfhS