Repository navigation
fluid system overhaul - #152
Open
The4codeblocks wants to merge 79 commits into
Open
The4codeblocks wants to merge 79 commits into
The4codeblocks wants to merge 79 commits into
Conversation
| -- or for rendering the pipes purely decorative. | ||
| ]] | ||
| pipeworks.toggles.pipe_mode = "classic" | ||
| pipeworks.toggles.pipe_mode = "pressure" |
Member
There was a problem hiding this comment.
how does that affect existing worlds?
Contributor
Author
There was a problem hiding this comment.
a lot of the things I'm doing (whether they're currently in this PR or not) are going to break things, but the old way things work is likely simple enough to auto-reinstate the original function
Member
|
Current luacheck warnings: (i removed the ones about missing sounds good imo, didn't test that yet though |
SwissalpS
reviewed
Dec 30, 2025
This comment was marked as spam.
This comment was marked as spam.
# Conflicts: # autocrafter.lua # trashcan.lua
Member
|
Rebase |
Contributor
Author
I tried that and it has conflicts all the way through. will just a merge be fine? |
Member
I'm fine with that. |
# Conflicts: # locale/template.txt # mod.conf
Contributor
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autocrafter fluid support
creative fluid source
trashcan acting as fluid void
flow sensor acting as a pressure gauge (shows fluid type too)
multiple fluid types (no mixing, but there is displacement)
| has custom fluid registration
| updating existing pump and drains to support multiple fluids
| per fluid "finite" config
(important detail: flow logic default set to
"pressure"instead of"classic")