Repository navigation
Conversation
q6asm_dai_ack() queues every period the application has written, one APR packet each, sent with rpmsg_trysend(). A large write can fill the SMD FIFO. q6asm_write_async() then returns -EAGAIN, and the ack fails, which stops the stream. Stop queueing on -EAGAIN instead, and push the remaining periods when the DSP hands a buffer back with DATA_WRITE_DONE. Both callers share the queueing loop under prtd->lock. Initialize that lock for PCM streams, which so far only the compress path did. Tested on MSM8916, where playback used to stop right after it started. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Vladimir Bely <vlwwwwww@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A full SMD FIFO (
-EAGAIN) while queueing periods was treated as fatal and stopped playback right after it started. The remaining periods are now sent when the DSP returns a buffer.Tested on a Samsung Galaxy A3 (SM-A300F, MSM8916) running LineageOS 24. Playback no longer stops at the start.
Per
CONTRIBUTING.mdthis touches a shared upstream driver, so it is posted here for early review before going to the upstream lists.