Skip to content

ASoC: qcom: q6asm-dai: Close the stream on every re-prepare - #457

Closed
vlw wants to merge 1 commit into
msm8916-mainline:wip/msm8916/7.0from
vlw:q6asm-dai-reprepare
Closed

vlw wants to merge 1 commit into
msm8916-mainline:wip/msm8916/7.0from
vlw:q6asm-dai-reprepare

Conversation

@vlw

@vlw vlw commented Nov 15, 2026

Copy link
Copy Markdown

A re-prepare after stop reopened a DSP stream that was still open, which the DSP rejects with ADSP_EALREADY. Playback then stayed silent.

Tested on a Samsung Galaxy A3 (SM-A300F, MSM8916) running LineageOS 24. Playback works repeatedly through the same PCM.

Per CONTRIBUTING.md this touches a shared upstream driver, so it is posted here for early review before going to the upstream lists.

q6asm_dai_prepare() closes the previous DSP stream only when it is
RUNNING. After TRIGGER_STOP or EOS the stream is STOPPED, but still
open in the DSP.

A second prepare then opens it again, as done for xrun recovery or
when an Android audio HAL leaves standby. The DSP rejects that with
ADSP_EALREADY, and playback stays silent from then on.

Close the stream in every state except IDLE.

Tested on MSM8916 by playing several times through the same PCM.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Vladimir Bely <vlwwwwww@gmail.com>
@vlw vlw closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant