Repository navigation
Conversation
q6asm_dai_prepare() closes the previous DSP stream only when it is RUNNING. After TRIGGER_STOP or EOS the stream is STOPPED, but still open in the DSP. A second prepare then opens it again, as done for xrun recovery or when an Android audio HAL leaves standby. The DSP rejects that with ADSP_EALREADY, and playback stays silent from then on. Close the stream in every state except IDLE. Tested on MSM8916 by playing several times through the same PCM. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Vladimir Bely <vlwwwwww@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A re-prepare after stop reopened a DSP stream that was still open, which the DSP rejects with
ADSP_EALREADY. Playback then stayed silent.Tested on a Samsung Galaxy A3 (SM-A300F, MSM8916) running LineageOS 24. Playback works repeatedly through the same PCM.
Per
CONTRIBUTING.mdthis touches a shared upstream driver, so it is posted here for early review before going to the upstream lists.